[Mojo Video Capture] Decouple VCController from VCBufferPool and VCDeviceClient

media/capture/video/video_capture_device.h

Index: media/capture/video/video_capture_device.h
diff --git a/media/capture/video/video_capture_device.h b/media/capture/video/video_capture_device.h
index dc0b77fb4f48e0817898e350515df779bfda6f42..d9b5ca9403474ea7a1dca1dad8161405ea0fc7e2 100644
--- a/media/capture/video/video_capture_device.h
+++ b/media/capture/video/video_capture_device.h
@@ -41,6 +41,15 @@ class Location;
 
 namespace media {
 
+class CAPTURE_EXPORT FrameBufferHost {

[mcasas, 2016/12/06 20:02:24]

In Chromium, Hosts are usually sitting at one end
of an IPC/mojo channel. To avoid confusion, we 
could consider calling this class e.g. FrameBufferPool?

[chfremer, 2016/12/06 21:07:41]

Done.

+ public:
+  virtual ~FrameBufferHost() {}
+
+  virtual void SetBufferHold(int buffer_id) = 0;
+  virtual void ReleaseBufferHold(int buffer_id) = 0;
+  virtual mojo::ScopedSharedBufferHandle GetHandleForTransit(int buffer_id) = 0;
+};

[mcasas, 2016/12/06 20:02:24]

Move it to a file on its own plz.

[chfremer, 2016/12/06 21:07:41]

Please allow me to defer this as cleanup task by adding it to the design doc.
Actually, this interface will be eliminated anyway in CL1.9.10.

+
 class CAPTURE_EXPORT VideoFrameConsumerFeedbackObserver {

[mcasas, 2016/12/06 20:02:24]

We should move this fella to a file on its own too.

And, incidentally, we should move these interface
definitions to media/capture ISO being buried
in media/capture/video. This can be done after
this CL.

[chfremer, 2016/12/06 21:07:41]

Agreed.
Please allow me to defer this as cleanup task by adding it to the design doc.

  public:
   virtual ~VideoFrameConsumerFeedbackObserver() {}
@@ -148,11 +157,10 @@ class CAPTURE_EXPORT VideoCaptureDevice
     // |timestamp|.
     // TODO(chfremer): Consider removing one of the two in order to simplify the
     // interface.
-    virtual void OnIncomingCapturedBuffer(
-        std::unique_ptr<Buffer> buffer,
-        const VideoCaptureFormat& frame_format,
-        base::TimeTicks reference_time,
-        base::TimeDelta timestamp) = 0;
+    virtual void OnIncomingCapturedBuffer(std::unique_ptr<Buffer> buffer,
+                                          const VideoCaptureFormat& format,
+                                          base::TimeTicks reference_time,
+                                          base::TimeDelta timestamp) = 0;
     virtual void OnIncomingCapturedVideoFrame(
         std::unique_ptr<Buffer> buffer,
         scoped_refptr<VideoFrame> frame) = 0;