Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: media/capture/video/video_capture_device.h

Issue 2551193002: [Mojo Video Capture] Decouple VCController from VCBufferPool and VCDeviceClient (Closed)
Patch Set: Added TODO comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device.h
diff --git a/media/capture/video/video_capture_device.h b/media/capture/video/video_capture_device.h
index dc0b77fb4f48e0817898e350515df779bfda6f42..e5612673aa8901422ef242e9db9cbd1336e8e9ff 100644
--- a/media/capture/video/video_capture_device.h
+++ b/media/capture/video/video_capture_device.h
@@ -41,6 +41,15 @@ class Location;
namespace media {
+class CAPTURE_EXPORT FrameBufferPool {
+ public:
+ virtual ~FrameBufferPool() {}
+
+ virtual void SetBufferHold(int buffer_id) = 0;
+ virtual void ReleaseBufferHold(int buffer_id) = 0;
+ virtual mojo::ScopedSharedBufferHandle GetHandleForTransit(int buffer_id) = 0;
+};
+
class CAPTURE_EXPORT VideoFrameConsumerFeedbackObserver {
public:
virtual ~VideoFrameConsumerFeedbackObserver() {}
@@ -148,11 +157,10 @@ class CAPTURE_EXPORT VideoCaptureDevice
// |timestamp|.
// TODO(chfremer): Consider removing one of the two in order to simplify the
// interface.
- virtual void OnIncomingCapturedBuffer(
- std::unique_ptr<Buffer> buffer,
- const VideoCaptureFormat& frame_format,
- base::TimeTicks reference_time,
- base::TimeDelta timestamp) = 0;
+ virtual void OnIncomingCapturedBuffer(std::unique_ptr<Buffer> buffer,
+ const VideoCaptureFormat& format,
+ base::TimeTicks reference_time,
+ base::TimeDelta timestamp) = 0;
virtual void OnIncomingCapturedVideoFrame(
std::unique_ptr<Buffer> buffer,
scoped_refptr<VideoFrame> frame) = 0;

Powered by Google App Engine
This is Rietveld 408576698