Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2551123004: Revert of Mark two crashing layout tests as crashing (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
Reviewers:
Adam Rice, hbos
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark two crashing layout tests as crashing (patchset #1 id:1 of https://codereview.chromium.org/2557723002/ ) Reason for revert: This is causing Path does not exist failures: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20711 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/27411 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/13691 (and more) Original issue's description: > Mark two crashing layout tests as crashing > > paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html [ Crash ] > virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html [ Crash ] > > BUG=671548 > TBR=hbos > NOTRY=true > > Committed: https://crrev.com/da043eb4bdb71a5311fc047500a3dd78a2f4bfb2 > Cr-Commit-Position: refs/heads/master@{#436557} TBR=hbos@webrtc.org,ricea@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671548 Committed: https://crrev.com/7a0e12c08a026b1ec2c458e61b2c5cc07c30b585 Cr-Commit-Position: refs/heads/master@{#436575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hbos_chromium
Created Revert of Mark two crashing layout tests as crashing
4 years ago (2016-12-06 12:04:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551123004/1
4 years ago (2016-12-06 12:05:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 12:06:07 UTC) #6
hbos_chromium
On 2016/12/06 12:04:50, hbos_chromium wrote: > Created Revert of Mark two crashing layout tests as ...
4 years ago (2016-12-06 12:06:39 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a0e12c08a026b1ec2c458e61b2c5cc07c30b585 Cr-Commit-Position: refs/heads/master@{#436575}
4 years ago (2016-12-06 12:08:44 UTC) #9
Adam Rice
On 2016/12/06 12:06:39, hbos_chromium wrote: > I don't get this. The file exists in codesearch. ...
4 years ago (2016-12-06 12:08:45 UTC) #10
hbos_chromium
4 years ago (2016-12-06 12:31:14 UTC) #11
Message was sent while issue was closed.
On 2016/12/06 12:08:45, Adam Rice wrote:
> On 2016/12/06 12:06:39, hbos_chromium wrote:
> > I don't get this. The file exists in codesearch. When a colleague did "git
cl
> > presubmit" he got these warnings. When I did on my machine I didn't get them
> at
> > ToT.
> 
> The chromium_presubmit tryjob passed too:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
> 
> I'm sure there's a reason for it.

Now the composited-cell-collapsed-border-add-anonymous.html crashes are back :)

Powered by Google App Engine
This is Rietveld 408576698