Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2551113002: clang/win: Enable full symbols on one of the ToT and one of the pinned bots. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
Reid Kleckner, hans
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable full symbols on one of the ToT and one of the pinned bots. This would've allowed us to find a crash with pchs on the bots. BUG=667891 Committed: https://crrev.com/566780fc9b55f2db1ba5a260589d3be0f6648e12 Cr-Commit-Position: refs/heads/master@{#436346}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nico
4 years ago (2016-12-05 16:56:45 UTC) #4
hans
lgtm
4 years ago (2016-12-05 17:10:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551113002/20001
4 years ago (2016-12-05 17:14:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 17:58:37 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 18:00:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/566780fc9b55f2db1ba5a260589d3be0f6648e12
Cr-Commit-Position: refs/heads/master@{#436346}

Powered by Google App Engine
This is Rietveld 408576698