[Mac] Opt browser window controller out of being a touch bar provider

[Mac] Opt browser window controller out of being a touch bar provider

Currently, on touch bar Macs, the system retains a reference to every
object it finds that conforms to the NSTouchBarProvider protocol, which
includes NSWindowController. If the user tries to quit Chrome when it
isn't foregrounded (for example, from the Dock icon context menu), these
references are never released, which means the browser window never
deallocs.

Since all browser windows being closed is a precondition of quitting,
Chrome never quits. There are a few private mechanisms to force the
touch bar to update its providers, but no matter what, the references
aren't released until Chrome is foregrounded.

This change effectively opts the window controller out of being a
touch bar provider which prevents it from being retained by the
touch bar mechanism in the first place.

BUG=667274
Review-Url: https://codereview.chromium.org/2550463002
Cr-Commit-Position: refs/heads/master@{#435759}
(cherry picked from commit 0098a25b70b91b23e87a4644e30722ba151e66e2)

Committed: https://chromium.googlesource.com/chromium/src/+/bae3d81964e15c28fd5ad0ccc562e54de83a103e

[Robert Sesek, 2016-12-05 16:04:27]

Description was changed from

==========
[Mac] Opt browser window controller out of being a touch bar provider

Currently, on touch bar Macs, the system retains a reference to every
object it finds that conforms to the NSTouchBarProvider protocol, which
includes NSWindowController. If the user tries to quit Chrome when it
isn't foregrounded (for example, from the Dock icon context menu), these
references are never released, which means the browser window never
deallocs.

Since all browser windows being closed is a precondition of quitting,
Chrome never quits. There are a few private mechanisms to force the
touch bar to update its providers, but no matter what, the references
aren't released until Chrome is foregrounded.

This change effectively opts the window controller out of being a
touch bar provider which prevents it from being retained by the
touch bar mechanism in the first place.

BUG=667274

Review-Url: https://codereview.chromium.org/2550463002
Cr-Commit-Position: refs/heads/master@{#435759}
(cherry picked from commit 0098a25b70b91b23e87a4644e30722ba151e66e2)
==========

to

==========
[Mac] Opt browser window controller out of being a touch bar provider

Currently, on touch bar Macs, the system retains a reference to every
object it finds that conforms to the NSTouchBarProvider protocol, which
includes NSWindowController. If the user tries to quit Chrome when it
isn't foregrounded (for example, from the Dock icon context menu), these
references are never released, which means the browser window never
deallocs.

Since all browser windows being closed is a precondition of quitting,
Chrome never quits. There are a few private mechanisms to force the
touch bar to update its providers, but no matter what, the references
aren't released until Chrome is foregrounded.

This change effectively opts the window controller out of being a
touch bar provider which prevents it from being retained by the
touch bar mechanism in the first place.

BUG=667274

Review-Url: https://codereview.chromium.org/2550463002
Cr-Commit-Position: refs/heads/master@{#435759}
(cherry picked from commit 0098a25b70b91b23e87a4644e30722ba151e66e2)

Committed:
https://chromium.googlesource.com/chromium/src/+/bae3d81964e15c28fd5ad0ccc562...
==========

[Robert Sesek, 2016-12-05 16:04:28]

Committed patchset #1 (id:1) manually as
bae3d81964e15c28fd5ad0ccc562e54de83a103e.