Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 2551073003: Instant Apps: Change the name of the metric. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Change the name of the metric. The metric is now recorded differently, update to a new name. BUG=670898 Committed: https://crrev.com/ba6c108d584629567b1bf45515b20ba90d6dee8d Cr-Commit-Position: refs/heads/master@{#436711}

Patch Set 1 #

Patch Set 2 : Reworded histogram desc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Maria
FYI, the changes to how the histogram is recorded were made downstream.
4 years ago (2016-12-05 23:29:19 UTC) #2
Ted C
lgtm
4 years ago (2016-12-06 00:47:04 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years ago (2016-12-06 15:44:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551073003/20001
4 years ago (2016-12-06 18:27:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 20:49:16 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-06 20:51:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba6c108d584629567b1bf45515b20ba90d6dee8d
Cr-Commit-Position: refs/heads/master@{#436711}

Powered by Google App Engine
This is Rietveld 408576698