[Sync] SyncEngine 1.5: Fix all backend references in PSS.

[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant

Committed: https://crrev.com/6b6f9f439dbd12d64de217f52dfe6b6c1af47291
Cr-Commit-Position: refs/heads/master@{#436462}

[maxbogue, 2016-12-05 19:00:29]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-12-05 19:00:30]

Sky, PTAL! This is all the changes stemming from updating PSS terminology.

[maxbogue, 2016-12-05 19:01:37]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 19:02:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-12-05 19:38:56]

lgtm

Lets make sure we do cleanup all the usage of backend in sync code before we
close out these bugs.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:159:
// Call the listener once, in case the sync backend is already initialized.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:211:
* Checks if sync is currently set to use a custom passphrase. The sync backend
must be running
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:238:
* Checks if the sync backend is running.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:362:
* If sync's backend is initialized, the button is enabled and the dialog will
present the
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:364:
* and the button will be disabled because the backend is needed in order to know
and
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:490:
// If the backend was shut down since the dialog was opened, do nothing.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:509:
// If the backend was shut down since the dialog was opened, do nothing.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:521:
// If the backend was shut down since the dialog was opened, do nothing.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:590:
* sync being turned on and the backend initialization completing.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:752:
* the encryption settings once the backend has initialized.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/sync/FakeProfileSyncService.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/sync/FakeProfileSyncService.java:14:
private boolean mBackendInitialized;
Should this variable get updated?

https://codereview.chromium.org/2551023006/diff/1/chrome/android/sync_shell/j...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java:142:
public void testOpeningSettingsDoesntStartBackend() throws Exception {
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.cc:726: // If we're
already waiting for the Sync backend, there's nothing to do here.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.cc:730: // Continue in
FinishSetupSync() once the Sync backend has been initialized.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
File chrome/browser/sync/sync_startup_tracker.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
chrome/browser/sync/sync_startup_tracker.cc:64: // If the sync backend has
started up, notify the callback.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
chrome/browser/sync/sync_startup_tracker.cc:79: // No error detected yet, but
the sync backend hasn't started up yet, so
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/profile_sync_service_harness.cc
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:52: class
BackendInitializeChecker : public SingleClientStatusChangeChecker {
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:60: //
Backend initialization is blocked by an auth error.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:63: //
Backend initialization is blocked by a failure to fetch Oauth2 tokens.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:66: //
Still waiting on backend initialization.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:249: bool
ProfileSyncServiceHarness::AwaitBackendInitialization() {
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:251:
LOG(ERROR) << "BackendInitializeChecker timed out.";
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:256:
LOG(ERROR) << "Service backend not initialized.";
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/profile_sync_service_harness.h
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:85: //
Blocks the caller until the sync backend is initialized or some end state
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:86: //
(e.g., auth error) is reached. Returns true if and only if the backend
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:88: //
method for the definition of backend initialization.
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:89: bool
AwaitBackendInitialization();
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/sync_errors_test.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_errors_test.cc:41: class
SyncBackendStoppedChecker : public SingleClientStatusChangeChecker {
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_errors_test.cc:203: // Tests that on
receiving CLIENT_DATA_OBSOLETE sync backend gets restarted and
backend

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/sync_setup_handler.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/sync_setup_handler.cc:465:
backend_start_timer_.reset();
Okay i'm gonna stop commenting, backend is everywhere...

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:362: const
syncer::WeakHandle<syncer::JsBackend>& js_backend,
And this gets less ambiguous! Woooo!

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:470: syncer::BackendMigrator*
GetBackendMigratorForTest();
Does this need to be renamed? What does the BackendMigrator even do? Do we need
to worry about USS migration happening at the same time as this thing?

[commit-bot: I haz the power, 2016-12-05 21:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:06:28]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-12-05 21:20:37]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 21:21:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 21:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:45:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[maxbogue, 2016-12-05 21:50:46]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 21:51:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-12-05 22:17:11]

Fixed a lot of other backend occurrences too, especially outside of sync (less
likely to be found later).

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:159:
// Call the listener once, in case the sync backend is already initialized.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:211:
* Checks if sync is currently set to use a custom passphrase. The sync backend
must be running
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:238:
* Checks if the sync backend is running.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:362:
* If sync's backend is initialized, the button is enabled and the dialog will
present the
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:364:
* and the button will be disabled because the backend is needed in order to know
and
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:490:
// If the backend was shut down since the dialog was opened, do nothing.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:509:
// If the backend was shut down since the dialog was opened, do nothing.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:521:
// If the backend was shut down since the dialog was opened, do nothing.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:590:
* sync being turned on and the backend initialization completing.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:752:
* the encryption settings once the backend has initialized.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/sync/FakeProfileSyncService.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/sync/FakeProfileSyncService.java:14:
private boolean mBackendInitialized;
On 2016/12/05 19:38:55, skym wrote:
> Should this variable get updated?

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/android/sync_shell/j...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java:142:
public void testOpeningSettingsDoesntStartBackend() throws Exception {
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.cc:726: // If we're
already waiting for the Sync backend, there's nothing to do here.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.cc:730: // Continue in
FinishSetupSync() once the Sync backend has been initialized.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
File chrome/browser/sync/sync_startup_tracker.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
chrome/browser/sync/sync_startup_tracker.cc:64: // If the sync backend has
started up, notify the callback.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/sync_st...
chrome/browser/sync/sync_startup_tracker.cc:79: // No error detected yet, but
the sync backend hasn't started up yet, so
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/profile_sync_service_harness.cc
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:52: class
BackendInitializeChecker : public SingleClientStatusChangeChecker {
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:60: //
Backend initialization is blocked by an auth error.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:63: //
Backend initialization is blocked by a failure to fetch Oauth2 tokens.
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:66: //
Still waiting on backend initialization.
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:249: bool
ProfileSyncServiceHarness::AwaitBackendInitialization() {
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:251:
LOG(ERROR) << "BackendInitializeChecker timed out.";
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:256:
LOG(ERROR) << "Service backend not initialized.";
On 2016/12/05 19:38:55, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/profile_sync_service_harness.h
(right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:85: //
Blocks the caller until the sync backend is initialized or some end state
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:86: //
(e.g., auth error) is reached. Returns true if and only if the backend
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:88: //
method for the definition of backend initialization.
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/profile_sync_service_harness.h:89: bool
AwaitBackendInitialization();
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/sync_errors_test.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_errors_test.cc:41: class
SyncBackendStoppedChecker : public SingleClientStatusChangeChecker {
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_errors_test.cc:203: // Tests that on
receiving CLIENT_DATA_OBSOLETE sync backend gets restarted and
On 2016/12/05 19:38:56, skym wrote:
> backend

Done.

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options/sync_setup_handler.cc (right):

https://codereview.chromium.org/2551023006/diff/1/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options/sync_setup_handler.cc:465:
backend_start_timer_.reset();
On 2016/12/05 19:38:56, skym wrote:
> Okay i'm gonna stop commenting, backend is everywhere...

Done.

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:362: const
syncer::WeakHandle<syncer::JsBackend>& js_backend,
On 2016/12/05 19:38:56, skym wrote:
> And this gets less ambiguous! Woooo!

:D

https://codereview.chromium.org/2551023006/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:470: syncer::BackendMigrator*
GetBackendMigratorForTest();
On 2016/12/05 19:38:56, skym wrote:
> Does this need to be renamed? What does the BackendMigrator even do? Do we
need
> to worry about USS migration happening at the same time as this thing?

I don't know, I'm ignoring it for now.

[maxbogue, 2016-12-05 22:22:21]

maxbogue@chromium.org changed reviewers:
+ dbeam@chromium.org, estade@chromium.org, nyquist@chromium.org,
pam@chromium.org, rajendrant@chromium.org

[maxbogue, 2016-12-05 22:22:21]

Adding OWNERs for non-sync files as follows:

nyquist:
  chrome/android/java/src/org/chromium/chrome/browser/gsa/ContextReporter.java
 
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
 
chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
 
chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
 
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java

pam:
  chrome/browser/supervised_user/supervised_user_service.cc

dbeam:
  chrome/browser/ui/webui/options/sync_setup_handler.cc
  chrome/browser/ui/webui/options/sync_setup_handler.h
  chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
  chrome/browser/ui/webui/settings/people_handler.cc
  chrome/browser/ui/webui/settings/people_handler.h
  chrome/browser/ui/webui/settings/people_handler_unittest.cc

rajendrant:
  components/precache/content/precache_manager.cc

estade:
  components/autofill/core/browser/autofill_experiments.cc

[Evan Stade, 2016-12-05 22:28:07]

> estade:
>   components/autofill/core/browser/autofill_experiments.cc

this lgtm (this is imo TBR-worthy)

[maxbogue, 2016-12-05 23:36:12]

On 2016/12/05 22:28:07, Evan Stade wrote:
> > estade:
> >   components/autofill/core/browser/autofill_experiments.cc
> 
> this lgtm (this is imo TBR-worthy)

You make a good point; I'll TBR the rest once the dry run passes.

[commit-bot: I haz the power, 2016-12-05 23:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 23:51:24]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-12-05 23:52:52]

Description was changed from

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
==========

to

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant
==========

[maxbogue, 2016-12-05 23:53:24]

TBR'ing nyquist, pam, and rajendrant.

[maxbogue, 2016-12-05 23:53:32]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-12-05 23:53:32]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2551023006/#ps40001
(title: "Fix Android.")

[commit-bot: I haz the power, 2016-12-05 23:53:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-12-05 23:57:45]

lgtm

[commit-bot: I haz the power, 2016-12-05 23:59:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480982012176810,
"parent_rev": "075afa67609ab62aa773ef3743147db8d503dde1", "commit_rev":
"c475031b5713a5a1e798a399fd6f7f06645299ad"}

[commit-bot: I haz the power, 2016-12-05 23:59:45]

Description was changed from

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant
==========

to

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant
==========

[commit-bot: I haz the power, 2016-12-05 23:59:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 00:01:55]

Description was changed from

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant
==========

to

==========
[Sync] SyncEngine 1.5: Fix all backend references in PSS.

There were a lot so I made a separate CL.

BUG=669967
TBR=nyquist,pam,rajendrant

Committed: https://crrev.com/6b6f9f439dbd12d64de217f52dfe6b6c1af47291
Cr-Commit-Position: refs/heads/master@{#436462}
==========

[commit-bot: I haz the power, 2016-12-06 00:01:56]

Patchset 3 (id:??) landed as
https://crrev.com/6b6f9f439dbd12d64de217f52dfe6b6c1af47291
Cr-Commit-Position: refs/heads/master@{#436462}