pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart - Issue 2551023005: Prepare for decoupling analyzer ASTs from element model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

Issue 2551023005: Prepare for decoupling analyzer ASTs from element model. (Closed)

Patch Set: Address review comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/analysis/update_content_test.dart ('k') | pkg/analysis_server/test/services/correction/assist_test.dart » ('j') | pkg/analyzer/lib/dart/ast/resolution_map.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

index 67e691a34fd1ace77b8a3af7ac98b382b82064a6..d212a5f01534361d377f28ac755568f6e52a74fe 100644

--- a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

+++ b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

@@ -11,6 +11,7 @@ import 'package:analysis_server/src/services/completion/completion_core.dart';

import 'package:analysis_server/src/services/completion/completion_performance.dart';

import 'package:analysis_server/src/services/completion/dart/completion_manager.dart';

import 'package:analysis_server/src/services/completion/dart/imported_reference_contributor.dart';

+import 'package:analyzer/dart/ast/standard_resolution_map.dart';

import 'package:analyzer/dart/element/element.dart';

import 'package:analyzer/src/task/dart.dart';

import 'package:test/test.dart';

@@ -76,7 +77,8 @@ part '$testFile';

var directives = request.target.unit.directives;

// Assert that the import does not have an export namespace

- expect(directives[0].element?.library?.exportNamespace, isNull);

+ Element element = resolutionMap.elementDeclaredByDirective(directives[0]);

+ expect(element?.library?.exportNamespace, isNull);

// Resolve directives

var importCompleter = new Completer<List<ImportElement>>();