Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 2551023005: Prepare for decoupling analyzer ASTs from element model. (Closed)
Patch Set: Address review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index 2fab11c4912a31fa856602c6a8369f3d3d95ae52..de1345f88f0ee0b8293fc8fdc61c0e3ac8ad6381 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -25,6 +25,7 @@ import 'package:analysis_server/src/services/correction/strings.dart';
import 'package:analysis_server/src/services/correction/util.dart';
import 'package:analysis_server/src/services/search/hierarchy.dart';
import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/ast/standard_resolution_map.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/type.dart';
@@ -602,7 +603,7 @@ class FixProcessor {
utils.getTypeSource(newType, librariesToImport);
_addReplaceEdit(rf.rangeNode(typeNode), newTypeSource);
_addFix(DartFixKind.CHANGE_TYPE_ANNOTATION,
- [typeNode.type.displayName, newTypeSource]);
+ [resolutionMap.typeForTypeName(typeNode), newTypeSource]);
}
}
}
@@ -2074,7 +2075,9 @@ class FixProcessor {
targetClassNode = targetTypeNode;
// maybe static
if (target is Identifier) {
- staticModifier = target.bestElement.kind == ElementKind.CLASS;
+ staticModifier =
+ resolutionMap.bestElementForIdentifier(target).kind ==
+ ElementKind.CLASS;
}
// use different utils
CompilationUnitElement targetUnitElement =

Powered by Google App Engine
This is Rietveld 408576698