pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart - Issue 2551023005: Prepare for decoupling analyzer ASTs from element model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart

Issue 2551023005: Prepare for decoupling analyzer ASTs from element model. (Closed)

Patch Set: Address review comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart » ('j') | pkg/analyzer/lib/dart/ast/resolution_map.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart

index cef91def59fe749c234320863e08cedbf8f2a426..ad8e2b4f9d65bf13e177c5d0fdb21ffa6d3072b7 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart

@@ -16,6 +16,7 @@ import 'package:analysis_server/src/services/completion/dart/local_declaration_v

import 'package:analysis_server/src/services/completion/dart/optype.dart';

import 'package:analysis_server/src/services/completion/dart/suggestion_builder.dart';

import 'package:analyzer/dart/ast/ast.dart';

+import 'package:analyzer/dart/ast/standard_resolution_map.dart';

import 'package:analyzer/dart/ast/standard_ast_factory.dart';

import 'package:analyzer/dart/ast/token.dart';

import 'package:analyzer/dart/element/element.dart';

@@ -248,8 +249,10 @@ class _Visitor extends LocalDeclarationVisitor {

String completion = classDecl.name.name;

SimpleIdentifier elemId;

+ ClassElement classElement =

+ resolutionMap.elementDeclaredByClassDeclaration(classDecl);

int relevance = optype.constructorSuggestionsFilter(

- classDecl.element?.type, DART_RELEVANCE_DEFAULT);

+ classElement?.type, DART_RELEVANCE_DEFAULT);

if (relevance == null) {

return;

}