pkg/analysis_server/lib/src/services/refactoring/extract_method.dart - Issue 2551023005: Prepare for decoupling analyzer ASTs from element model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

Issue 2551023005: Prepare for decoupling analyzer ASTs from element model. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/index/index_unit.dart ('k') | pkg/analysis_server/test/analysis/update_content_test.dart » ('j') | pkg/analyzer/lib/dart/ast/resolution_accessors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

index 107abf3d74f6ee955c2be1ef2056439a7fdeeb20..8dcbaab517432c8f97c970f4851e70a2a4fc5dd8 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

@@ -21,6 +21,7 @@ import 'package:analysis_server/src/services/refactoring/rename_unit_member.dart

import 'package:analysis_server/src/services/search/element_visitors.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/dart/ast/ast.dart';

+import 'package:analyzer/dart/ast/resolution_accessors.dart';

import 'package:analyzer/dart/ast/token.dart';

import 'package:analyzer/dart/ast/visitor.dart';

import 'package:analyzer/dart/element/element.dart';

@@ -411,7 +412,7 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl

AstNode parent = _parentMember.parent;

// top-level function

if (parent is CompilationUnit) {

- LibraryElement libraryElement = parent.element.library;

+ LibraryElement libraryElement = elementForCompilationUnit(parent).library;

return validateCreateFunction(searchEngine, libraryElement, name);

}

// method of class