Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 2551023005: Prepare for decoupling analyzer ASTs from element model. (Closed)
Patch Set: Address review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.completion.contributor.dart.local_ref; 5 library services.completion.contributor.dart.local_ref;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol 9 import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol
10 show Element, ElementKind; 10 show Element, ElementKind;
11 import 'package:analysis_server/src/provisional/completion/dart/completion_dart. dart'; 11 import 'package:analysis_server/src/provisional/completion/dart/completion_dart. dart';
12 import 'package:analysis_server/src/services/completion/dart/completion_manager. dart' 12 import 'package:analysis_server/src/services/completion/dart/completion_manager. dart'
13 show DartCompletionRequestImpl; 13 show DartCompletionRequestImpl;
14 import 'package:analysis_server/src/services/completion/dart/local_declaration_v isitor.dart' 14 import 'package:analysis_server/src/services/completion/dart/local_declaration_v isitor.dart'
15 show LocalDeclarationVisitor; 15 show LocalDeclarationVisitor;
16 import 'package:analysis_server/src/services/completion/dart/optype.dart'; 16 import 'package:analysis_server/src/services/completion/dart/optype.dart';
17 import 'package:analysis_server/src/services/correction/strings.dart'; 17 import 'package:analysis_server/src/services/correction/strings.dart';
18 import 'package:analysis_server/src/utilities/documentation.dart'; 18 import 'package:analysis_server/src/utilities/documentation.dart';
19 import 'package:analyzer/dart/ast/ast.dart'; 19 import 'package:analyzer/dart/ast/ast.dart';
20 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
20 import 'package:analyzer/dart/ast/standard_ast_factory.dart'; 21 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
21 import 'package:analyzer/dart/ast/token.dart'; 22 import 'package:analyzer/dart/ast/token.dart';
22 import 'package:analyzer/dart/element/element.dart'; 23 import 'package:analyzer/dart/element/element.dart';
23 import 'package:analyzer/dart/element/type.dart'; 24 import 'package:analyzer/dart/element/type.dart';
24 import 'package:analyzer/src/dart/ast/token.dart'; 25 import 'package:analyzer/src/dart/ast/token.dart';
25 import 'package:analyzer/src/generated/source.dart'; 26 import 'package:analyzer/src/generated/source.dart';
26 import 'package:analyzer/src/generated/utilities_dart.dart' show ParameterKind; 27 import 'package:analyzer/src/generated/utilities_dart.dart' show ParameterKind;
27 28
28 import '../../../protocol_server.dart' 29 import '../../../protocol_server.dart'
29 show CompletionSuggestion, CompletionSuggestionKind, Location; 30 show CompletionSuggestion, CompletionSuggestionKind, Location;
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 relevance: relevance); 514 relevance: relevance);
514 } 515 }
515 } 516 }
516 517
517 void _addLocalSuggestion_includeReturnValueSuggestions_enumConstant( 518 void _addLocalSuggestion_includeReturnValueSuggestions_enumConstant(
518 EnumConstantDeclaration constantDeclaration, 519 EnumConstantDeclaration constantDeclaration,
519 EnumDeclaration enumDeclaration, 520 EnumDeclaration enumDeclaration,
520 {bool isAbstract: false, 521 {bool isAbstract: false,
521 bool isDeprecated: false, 522 bool isDeprecated: false,
522 int relevance: DART_RELEVANCE_DEFAULT}) { 523 int relevance: DART_RELEVANCE_DEFAULT}) {
523 relevance = optype.returnValueSuggestionsFilter( 524 ClassElement classElement =
524 enumDeclaration.element?.type, relevance); 525 resolutionMap.elementDeclaredByEnumDeclaration(enumDeclaration);
526 relevance =
527 optype.returnValueSuggestionsFilter(classElement?.type, relevance);
525 if (relevance != null) { 528 if (relevance != null) {
526 _addLocalSuggestion_enumConstant(constantDeclaration, enumDeclaration, 529 _addLocalSuggestion_enumConstant(constantDeclaration, enumDeclaration,
527 isAbstract: isAbstract, 530 isAbstract: isAbstract,
528 isDeprecated: isDeprecated, 531 isDeprecated: isDeprecated,
529 relevance: relevance); 532 relevance: relevance);
530 } 533 }
531 } 534 }
532 535
533 void _addLocalSuggestion_includeTypeNameSuggestions( 536 void _addLocalSuggestion_includeTypeNameSuggestions(
534 Comment documentationComment, 537 Comment documentationComment,
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 String text = documentationComment.tokens 620 String text = documentationComment.tokens
618 .map((Token t) => t.toString()) 621 .map((Token t) => t.toString())
619 .join('\n') 622 .join('\n')
620 .replaceAll('\r\n', '\n'); 623 .replaceAll('\r\n', '\n');
621 String doc = removeDartDocDelimiters(text); 624 String doc = removeDartDocDelimiters(text);
622 suggestion.docComplete = doc; 625 suggestion.docComplete = doc;
623 suggestion.docSummary = getDartDocSummary(doc); 626 suggestion.docSummary = getDartDocSummary(doc);
624 } 627 }
625 } 628 }
626 } 629 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698