Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2551013003: Introduce ServiceWorker.MainFramePageLoad.CoreTransition and RedirectChainLength UMAs. (Closed)
Patch Set: Add comment about where the 20 is defined Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index 58e7c16f31426628029c7d1e451967614d329e01..93dd303945c63b2d5a9685b0a20af34ab7bb01a4 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -19,11 +19,13 @@
#include "content/common/service_worker/service_worker_types.h"
#include "content/common/service_worker/service_worker_utils.h"
#include "content/public/browser/content_browser_client.h"
+#include "content/public/browser/resource_request_info.h"
#include "content/public/common/content_client.h"
#include "content/public/common/resource_response_info.h"
#include "net/base/load_flags.h"
#include "net/base/url_util.h"
#include "net/url_request/url_request.h"
+#include "ui/base/page_transition_types.h"
namespace content {
@@ -45,6 +47,14 @@ bool MaybeForwardToServiceWorker(ServiceWorkerURLRequestJob* job,
return false;
}
+ui::PageTransition GetPageTransition(net::URLRequest* request) {
+ const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
+ // ResourceRequestInfo may not be set in some tests.
+ if (!info)
+ return ui::PAGE_TRANSITION_LINK;
+ return info->GetPageTransition();
+}
+
} // namespace
ServiceWorkerControlleeRequestHandler::ServiceWorkerControlleeRequestHandler(
@@ -285,9 +295,9 @@ void ServiceWorkerControlleeRequestHandler::
DCHECK_NE(active_version->fetch_handler_existence(),
ServiceWorkerVersion::FetchHandlerExistence::UNKNOWN);
-
ServiceWorkerMetrics::CountControlledPageLoad(
- active_version->site_for_uma(), stripped_url_, is_main_frame_load_);
+ active_version->site_for_uma(), stripped_url_, is_main_frame_load_,
+ GetPageTransition(job_->request()), job_->request()->url_chain().size());
bool is_forwarded =
MaybeForwardToServiceWorker(job_.get(), active_version.get());
@@ -319,7 +329,8 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(
DCHECK_NE(version->fetch_handler_existence(),
ServiceWorkerVersion::FetchHandlerExistence::UNKNOWN);
ServiceWorkerMetrics::CountControlledPageLoad(
- version->site_for_uma(), stripped_url_, is_main_frame_load_);
+ version->site_for_uma(), stripped_url_, is_main_frame_load_,
+ GetPageTransition(job_->request()), job_->request()->url_chain().size());
provider_host_->AssociateRegistration(registration,
false /* notify_controllerchange */);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698