ui/compositor/layer_animation_sequence.cc - Issue 2550933002: Make all LayerAnimationElement::Create*Element return unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/compositor/layer_animation_sequence.cc

Issue 2550933002: Make all LayerAnimationElement::Create*Element return unique_ptr (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/compositor/layer_animation_sequence.cc

diff --git a/ui/compositor/layer_animation_sequence.cc b/ui/compositor/layer_animation_sequence.cc

index f4919f381a177dfec53e57824254c4ff5e19a194..7c074a67d3be469b75fbc072b4a0c6d93a50e97d 100644

--- a/ui/compositor/layer_animation_sequence.cc

+++ b/ui/compositor/layer_animation_sequence.cc

@@ -184,7 +184,7 @@ void LayerAnimationSequence::Abort(LayerAnimationDelegate* delegate) {

void LayerAnimationSequence::AddElement(LayerAnimationElement* element) {

loyso (OOO) 2016/12/06 04:21:56 AddElement(std::unique_ptr<LayerAnimationElement>

properties_ |= element->properties();

- elements_.push_back(make_linked_ptr(element));

+ elements_.emplace_back(element);

loyso (OOO) 2016/12/06 04:21:56 push_back(std::move(element))

}

bool LayerAnimationSequence::HasConflictingProperty(