Make all LayerAnimationElement::Create*Element return unique_ptr

ui/compositor/layer_animation_sequence.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_COMPOSITOR_LAYER_ANIMATION_SEQUENCE_H_
 #define UI_COMPOSITOR_LAYER_ANIMATION_SEQUENCE_H_
 
 #include <stddef.h>
 
 #include <vector>
@@ skipping 23 matching lines @@
 // TODO(vollick) Eventually, the LayerAnimator will switch to a model where new
 // work is scheduled rather than calling methods directly. This should make it
 // impossible for temporary pointers to running animations to go stale. When
 // this happens, there will be no need for LayerAnimationSequences to support
 // weak pointers.
 class COMPOSITOR_EXPORT LayerAnimationSequence
     : public base::SupportsWeakPtr<LayerAnimationSequence> {
  public:
   LayerAnimationSequence();
   // Takes ownership of the given element and adds it to the sequence.
-  explicit LayerAnimationSequence(LayerAnimationElement* element);
+  explicit LayerAnimationSequence(
+      std::unique_ptr<LayerAnimationElement> element);
   virtual ~LayerAnimationSequence();
 
   // Sets the start time for the animation. This must be called before the
   // first call to {Start, IsFinished}. Once the animation is finished, this
   // must be called again in order to restart the animation.
   void set_start_time(base::TimeTicks start_time) { start_time_ = start_time; }
   base::TimeTicks start_time() const { return start_time_; }
 
   // Sets a flag indicating that this sequence will start together with other
   // sequences, and at least one of the sequences in this group has a threaded
@@ skipping 28 matching lines @@
   // Aborts the given animation.
   void Abort(LayerAnimationDelegate* delegate);
 
   // All properties modified by the sequence.
   LayerAnimationElement::AnimatableProperties properties() const {
     return properties_;
   }
 
   // Adds an element to the sequence. The sequences takes ownership of this
   // element.
-  void AddElement(LayerAnimationElement* element);
+  void AddElement(std::unique_ptr<LayerAnimationElement> element);
 
   // Sequences can be looped indefinitely.
   void set_is_cyclic(bool is_cyclic) { is_cyclic_ = is_cyclic; }
   bool is_cyclic() const { return is_cyclic_; }
 
   // Returns true if this sequence has at least one element conflicting with a
   // property in |other|.
   bool HasConflictingProperty(
       LayerAnimationElement::AnimatableProperties other) const;
 
@@ skipping 26 matching lines @@
   // by this sequence. Returns 0.0 if no elements have been progressed.
   double last_progressed_fraction() const { return last_progressed_fraction_; }
 
   size_t size() const;
 
   LayerAnimationElement* FirstElement() const;
 
  private:
   friend class LayerAnimatorTestController;
 
-  typedef std::vector<linked_ptr<LayerAnimationElement> > Elements;

[loyso (OOO), 2016/12/13 02:26:54]

Could you erase linked_ptr include dependency? It was erased in previous
patchsets, AFAIR.

+  using Elements = std::vector<std::unique_ptr<LayerAnimationElement>>;
 
   FRIEND_TEST_ALL_PREFIXES(LayerAnimatorTest,
                            ObserverReleasedBeforeAnimationSequenceEnds);
 
   // Notifies the observers that this sequence has been scheduled.
   void NotifyScheduled();
 
   // Notifies the observers that this sequence has been started.
   void NotifyStarted();
 
@@ skipping 40 matching lines @@
   double last_progressed_fraction_;
 
   base::WeakPtrFactory<LayerAnimationSequence> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LayerAnimationSequence);
 };
 
 }  // namespace ui
 
 #endif  // UI_COMPOSITOR_LAYER_ANIMATION_SEQUENCE_H_