Make all LayerAnimationElement::Create*Element return unique_ptr

ui/wm/core/window_animations.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/wm/core/window_animations.h"
 
 #include <math.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 333 matching lines @@
 
 // Show/Hide windows using a fade.
 void AnimateShowWindow_Fade(aura::Window* window) {
   AnimateShowWindowCommon(window, gfx::Transform(), gfx::Transform());
 }
 
 void AnimateHideWindow_Fade(aura::Window* window) {
   AnimateHideWindowCommon(window, gfx::Transform());
 }
 
-ui::LayerAnimationElement* CreateGrowShrinkElement(
-    aura::Window* window, bool grow) {
+std::unique_ptr<ui::LayerAnimationElement> CreateGrowShrinkElement(
+    aura::Window* window,
+    bool grow) {
   std::unique_ptr<ui::InterpolatedTransform> scale(
       new ui::InterpolatedScale(gfx::Point3F(kWindowAnimation_Bounce_Scale,
                                              kWindowAnimation_Bounce_Scale, 1),
                                 gfx::Point3F(1, 1, 1)));
   std::unique_ptr<ui::InterpolatedTransform> scale_about_pivot(
       new ui::InterpolatedTransformAboutPivot(
           gfx::Point(window->bounds().width() * 0.5,
                      window->bounds().height() * 0.5),
           scale.release()));
   scale_about_pivot->SetReversed(grow);
-  std::unique_ptr<ui::LayerAnimationElement> transition(
+  std::unique_ptr<ui::LayerAnimationElement> transition =
       ui::LayerAnimationElement::CreateInterpolatedTransformElement(
           scale_about_pivot.release(),
           base::TimeDelta::FromMilliseconds(
               kWindowAnimation_Bounce_DurationMS *
-              kWindowAnimation_Bounce_GrowShrinkDurationPercent / 100)));
+              kWindowAnimation_Bounce_GrowShrinkDurationPercent / 100));
   transition->set_tween_type(grow ? gfx::Tween::EASE_OUT : gfx::Tween::EASE_IN);
-  return transition.release();
+  return transition;
 }
 
 void AnimateBounce(aura::Window* window) {
   ui::ScopedLayerAnimationSettings scoped_settings(
       window->layer()->GetAnimator());
   scoped_settings.SetPreemptionStrategy(
       ui::LayerAnimator::REPLACE_QUEUED_ANIMATIONS);
   std::unique_ptr<ui::LayerAnimationSequence> sequence(
       new ui::LayerAnimationSequence);
   sequence->AddElement(CreateGrowShrinkElement(window, true));
@@ skipping 45 matching lines @@
       kWindowAnimation_Rotate_DurationMS);
 
   RotateHidingWindowAnimationObserver* observer = NULL;
 
   if (!show) {
     observer = new RotateHidingWindowAnimationObserver(window);
     window->layer()->GetAnimator()->SchedulePauseForProperties(
         duration * (100 - kWindowAnimation_Rotate_OpacityDurationPercent) / 100,
         ui::LayerAnimationElement::OPACITY);
   }
-  std::unique_ptr<ui::LayerAnimationElement> opacity(
+  std::unique_ptr<ui::LayerAnimationElement> opacity =
       ui::LayerAnimationElement::CreateOpacityElement(
           show ? kWindowAnimation_ShowOpacity : kWindowAnimation_HideOpacity,
-          duration * kWindowAnimation_Rotate_OpacityDurationPercent / 100));
+          duration * kWindowAnimation_Rotate_OpacityDurationPercent / 100);
   opacity->set_tween_type(gfx::Tween::EASE_IN_OUT);
   window->layer()->GetAnimator()->ScheduleAnimation(
       new ui::LayerAnimationSequence(opacity.release()));
 
   float xcenter = window->bounds().width() * 0.5;
 
   gfx::Transform transform;
   transform.Translate(xcenter, 0);
   transform.ApplyPerspectiveDepth(kWindowAnimation_Rotate_PerspectiveDepth);
   transform.Translate(-xcenter, 0);
@@ skipping 13 matching lines @@
 
   std::unique_ptr<ui::InterpolatedTransform> rotation(
       new ui::InterpolatedAxisAngleRotation(gfx::Vector3dF(1, 0, 0), 0,
                                             kWindowAnimation_Rotate_DegreesX));
 
   scale_about_pivot->SetChild(perspective.release());
   translation->SetChild(scale_about_pivot.release());
   rotation->SetChild(translation.release());
   rotation->SetReversed(show);
 
-  std::unique_ptr<ui::LayerAnimationElement> transition(
+  std::unique_ptr<ui::LayerAnimationElement> transition =
       ui::LayerAnimationElement::CreateInterpolatedTransformElement(
-          rotation.release(), duration));
+          rotation.release(), duration);

[loyso (OOO), 2016/12/08 00:05:21]

std::move ?

   ui::LayerAnimationSequence* last_sequence =
-      new ui::LayerAnimationSequence(transition.release());
+      new ui::LayerAnimationSequence(std::move(transition));
   window->layer()->GetAnimator()->ScheduleAnimation(last_sequence);
 
   if (observer) {
     observer->SetLastSequence(last_sequence);
     observer->DetachAndRecreateLayers();
   }
 }
 
 void AnimateShowWindow_Rotate(aura::Window* window) {
   AddLayerAnimationsForRotate(window, true);
@@ skipping 169 matching lines @@
   // being accessed via Remote Desktop.
   if (ui::ScopedAnimationDurationScaleMode::duration_scale_mode() ==
       ui::ScopedAnimationDurationScaleMode::NON_ZERO_DURATION)
     return false;
 
   // Let the user decide whether or not to play the animation.
   return !gfx::Animation::ShouldRenderRichAnimation();
 }
 
 }  // namespace wm