Make all LayerAnimationElement::Create*Element return unique_ptr

ui/compositor/layer_animation_sequence.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer_animation_sequence.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/animation/animation_id_provider.h"
 #include "ui/compositor/layer_animation_delegate.h"
 #include "ui/compositor/layer_animation_element.h"
 #include "ui/compositor/layer_animation_observer.h"
 
 namespace ui {
 
 LayerAnimationSequence::LayerAnimationSequence()
     : properties_(LayerAnimationElement::UNKNOWN),
       is_cyclic_(false),
       last_element_(0),
       waiting_for_group_start_(false),
       animation_group_id_(0),
       last_progressed_fraction_(0.0),
       weak_ptr_factory_(this) {
 }
 
-LayerAnimationSequence::LayerAnimationSequence(LayerAnimationElement* element)
+LayerAnimationSequence::LayerAnimationSequence(
+    std::unique_ptr<LayerAnimationElement> element)
     : properties_(LayerAnimationElement::UNKNOWN),
       is_cyclic_(false),
       last_element_(0),
       waiting_for_group_start_(false),
       animation_group_id_(0),
       last_progressed_fraction_(0.0),
       weak_ptr_factory_(this) {
-  AddElement(element);
+  AddElement(std::move(element));
 }
 
 LayerAnimationSequence::~LayerAnimationSequence() {
   for (auto& observer : observers_)
     observer.DetachedFromSequence(this, true);
 }
 
 void LayerAnimationSequence::Start(LayerAnimationDelegate* delegate) {
   DCHECK(start_time_ != base::TimeTicks());
   last_progressed_fraction_ = 0.0;
@@ skipping 128 matching lines @@
   size_t current_index = last_element_ % elements_.size();
   while (current_index < elements_.size()) {
     elements_[current_index]->Abort(delegate);
     ++current_index;
   }
   last_element_ = 0;
   waiting_for_group_start_ = false;
   NotifyAborted();
 }
 
-void LayerAnimationSequence::AddElement(LayerAnimationElement* element) {
+void LayerAnimationSequence::AddElement(
+    std::unique_ptr<LayerAnimationElement> element) {
   properties_ |= element->properties();
-  elements_.push_back(make_linked_ptr(element));
+  elements_.push_back(std::move(element));

[sky, 2016/12/15 16:42:18]

push_back->emplace_back?

[Sunny, 2016/12/16 10:53:49]

Emm...Do you prefer emplace_back(std::move(element)) or
emplace_back(element.release())?

[danakj, 2016/12/16 14:20:31]

Never use release() unless you really have to. Since you have the type that is
being stored in the array already push_back should make sense here IMO.
emplace_back would be for constructing a new type from a constructor call (not a
copy/move constructor).

 }
 
 bool LayerAnimationSequence::HasConflictingProperty(
     LayerAnimationElement::AnimatableProperties other) const {
   return (properties_ & other) != LayerAnimationElement::UNKNOWN;
 }
 
 bool LayerAnimationSequence::IsFirstElementThreaded() const {
   if (!elements_.empty())
     return elements_[0]->IsThreaded();
@@ skipping 77 matching lines @@
 
 LayerAnimationElement* LayerAnimationSequence::CurrentElement() const {
   if (elements_.empty())
     return NULL;
 
   size_t current_index = last_element_ % elements_.size();
   return elements_[current_index].get();
 }
 
 }  // namespace ui