Make all LayerAnimationElement::Create*Element return unique_ptr

ui/compositor/layer_animation_element_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer_animation_element.h"
 
 #include <memory>
 
 #include "base/compiler_specific.h"
 #include "base/time/time.h"
@@ skipping 44 matching lines @@
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, TransformElement) {
   TestLayerAnimationDelegate delegate;
   gfx::Transform start_transform, target_transform;
   start_transform.Rotate(-30.0);
   target_transform.Rotate(30.0);
   base::TimeTicks start_time;
   base::TimeTicks effective_start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
 
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateTransformElement(target_transform, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateTransformElement(target_transform, delta);
   element->set_animation_group_id(1);
 
   for (int i = 0; i < 2; ++i) {
     start_time = effective_start_time + delta;
     element->set_requested_start_time(start_time);
     delegate.SetTransformFromAnimation(start_transform);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     CheckApproximatelyEqual(start_transform,
                             delegate.GetTransformForAnimation());
@@ skipping 24 matching lines @@
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, BoundsElement) {
   TestLayerAnimationDelegate delegate;
   gfx::Rect start, target, middle;
   start = target = middle = gfx::Rect(0, 0, 50, 50);
   start.set_x(-90);
   target.set_x(90);
   base::TimeTicks start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
 
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateBoundsElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateBoundsElement(target, delta);
 
   for (int i = 0; i < 2; ++i) {
     start_time += delta;
     element->set_requested_start_time(start_time);
     delegate.SetBoundsFromAnimation(start);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     CheckApproximatelyEqual(start, delegate.GetBoundsForAnimation());
     element->Progress(start_time + delta/2, &delegate);
     CheckApproximatelyEqual(middle, delegate.GetBoundsForAnimation());
@@ skipping 14 matching lines @@
 // Check that the opacity element progresses the delegate as expected and
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, OpacityElement) {
   TestLayerAnimationDelegate delegate;
   float start = 0.0;
   float middle = 0.5;
   float target = 1.0;
   base::TimeTicks start_time;
   base::TimeTicks effective_start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateOpacityElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateOpacityElement(target, delta);
 
   for (int i = 0; i < 2; ++i) {
     start_time = effective_start_time + delta;
     element->set_requested_start_time(start_time);
     delegate.SetOpacityFromAnimation(start);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     EXPECT_FLOAT_EQ(start, element->last_progressed_fraction());
     effective_start_time = start_time + delta;
     element->set_effective_start_time(effective_start_time);
@@ skipping 18 matching lines @@
 }
 
 // Check that the visibility element progresses the delegate as expected and
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, VisibilityElement) {
   TestLayerAnimationDelegate delegate;
   bool start = true;
   bool target = false;
   base::TimeTicks start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateVisibilityElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateVisibilityElement(target, delta);
 
   for (int i = 0; i < 2; ++i) {
     start_time += delta;
     element->set_requested_start_time(start_time);
     delegate.SetVisibilityFromAnimation(start);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     EXPECT_TRUE(delegate.GetVisibilityForAnimation());
     element->Progress(start_time + delta/2, &delegate);
     EXPECT_TRUE(delegate.GetVisibilityForAnimation());
@@ skipping 13 matching lines @@
 
 // Check that the Brightness element progresses the delegate as expected and
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, BrightnessElement) {
   TestLayerAnimationDelegate delegate;
   float start = 0.0;
   float middle = 0.5;
   float target = 1.0;
   base::TimeTicks start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateBrightnessElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateBrightnessElement(target, delta);
 
   for (int i = 0; i < 2; ++i) {
     start_time += delta;
     element->set_requested_start_time(start_time);
     delegate.SetBrightnessFromAnimation(start);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     EXPECT_FLOAT_EQ(start, delegate.GetBrightnessForAnimation());
     element->Progress(start_time + delta/2, &delegate);
     EXPECT_FLOAT_EQ(middle, delegate.GetBrightnessForAnimation());
@@ skipping 13 matching lines @@
 
 // Check that the Grayscale element progresses the delegate as expected and
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, GrayscaleElement) {
   TestLayerAnimationDelegate delegate;
   float start = 0.0;
   float middle = 0.5;
   float target = 1.0;
   base::TimeTicks start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateGrayscaleElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateGrayscaleElement(target, delta);
 
   for (int i = 0; i < 2; ++i) {
     start_time += delta;
     element->set_requested_start_time(start_time);
     delegate.SetGrayscaleFromAnimation(start);
     element->Start(&delegate, 1);
     element->Progress(start_time, &delegate);
     EXPECT_FLOAT_EQ(start, delegate.GetGrayscaleForAnimation());
     element->Progress(start_time + delta/2, &delegate);
     EXPECT_FLOAT_EQ(middle, delegate.GetGrayscaleForAnimation());
@@ skipping 15 matching lines @@
 // that the element can be reused after it completes.
 TEST(LayerAnimationElementTest, PauseElement) {
   LayerAnimationElement::AnimatableProperties properties =
       LayerAnimationElement::TRANSFORM | LayerAnimationElement::BOUNDS |
       LayerAnimationElement::OPACITY | LayerAnimationElement::BRIGHTNESS |
       LayerAnimationElement::GRAYSCALE;
 
   base::TimeTicks start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
 
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreatePauseElement(properties, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreatePauseElement(properties, delta);
 
   TestLayerAnimationDelegate delegate;
   TestLayerAnimationDelegate copy = delegate;
 
   start_time += delta;
   element->set_requested_start_time(start_time);
   element->Start(&delegate, 1);
 
   // Pause should last for |delta|.
   base::TimeDelta element_duration;
@@ skipping 17 matching lines @@
 
 // Check that a threaded opacity element updates the delegate as expected when
 // aborted.
 TEST(LayerAnimationElementTest, AbortOpacityElement) {
   TestLayerAnimationDelegate delegate;
   float start = 0.0;
   float target = 1.0;
   base::TimeTicks start_time;
   base::TimeTicks effective_start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateOpacityElement(target, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateOpacityElement(target, delta);
 
   // Choose a non-linear Tween type.
   gfx::Tween::Type tween_type = gfx::Tween::EASE_IN;
   element->set_tween_type(tween_type);
 
   delegate.SetOpacityFromAnimation(start);
 
   // Aborting the element before it has started should not update the delegate.
   element->Abort(&delegate);
   EXPECT_FLOAT_EQ(start, delegate.GetOpacityForAnimation());
@@ skipping 17 matching lines @@
 // Check that a threaded transform element updates the delegate as expected when
 // aborted.
 TEST(LayerAnimationElementTest, AbortTransformElement) {
   TestLayerAnimationDelegate delegate;
   gfx::Transform start_transform, target_transform;
   start_transform.Rotate(-30.0);
   target_transform.Rotate(30.0);
   base::TimeTicks start_time;
   base::TimeTicks effective_start_time;
   base::TimeDelta delta = base::TimeDelta::FromSeconds(1);
-  std::unique_ptr<LayerAnimationElement> element(
-      LayerAnimationElement::CreateTransformElement(target_transform, delta));
+  std::unique_ptr<LayerAnimationElement> element =
+      LayerAnimationElement::CreateTransformElement(target_transform, delta);
 
   // Choose a non-linear Tween type.
   gfx::Tween::Type tween_type = gfx::Tween::EASE_IN;
   element->set_tween_type(tween_type);
 
   delegate.SetTransformFromAnimation(start_transform);
 
   // Aborting the element before it has started should not update the delegate.
   element->Abort(&delegate);
   CheckApproximatelyEqual(start_transform, delegate.GetTransformForAnimation());
@@ skipping 12 matching lines @@
   element->Abort(&delegate);
   target_transform.Blend(start_transform,
                          gfx::Tween::CalculateValue(tween_type, 0.5));
   CheckApproximatelyEqual(target_transform,
                           delegate.GetTransformForAnimation());
 }
 
 } // namespace
 
 } // namespace ui