Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2550903002: Fix csp mode on platforms that don't support __proto__. (Closed)

Created:
4 years ago by floitsch
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix csp mode on platforms that don't support __proto__. Fixes #27290 BUG= http://dartbug.com/27290 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/80da37ed2544ff8fb39b20c970096d0fd204fd5a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/mixin_proto_test.dart View 1 chunk +36 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
floitsch
4 years ago (2016-12-03 01:16:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-04 04:36:09 UTC) #3
Siggi Cherem (dart-lang)
thanks Florian!
4 years ago (2016-12-04 04:36:43 UTC) #4
floitsch
Committed patchset #1 (id:1) manually as 80da37ed2544ff8fb39b20c970096d0fd204fd5a (presubmit successful).
4 years ago (2016-12-06 13:31:58 UTC) #6
sra1
https://codereview.chromium.org/2550903002/diff/1/tests/language/mixin_proto_test.dart File tests/language/mixin_proto_test.dart (right): https://codereview.chromium.org/2550903002/diff/1/tests/language/mixin_proto_test.dart#newcode30 tests/language/mixin_proto_test.dart:30: var all = [new A(), new B(), new C()]; ...
3 years, 10 months ago (2017-02-23 23:43:40 UTC) #8
floitsch
3 years, 10 months ago (2017-02-24 12:35:29 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/2550903002/diff/1/tests/language/mixin_proto_...
File tests/language/mixin_proto_test.dart (right):

https://codereview.chromium.org/2550903002/diff/1/tests/language/mixin_proto_...
tests/language/mixin_proto_test.dart:30: var all = [new A(), new B(), new C()];
On 2017/02/23 23:43:39, sra1 wrote:
> Always use a 'confuse' function to obfuscate.
> It would take only a couple of tweaks to type inference to be able to inline
the
> calls.

https://codereview.chromium.org/2712603006/

Powered by Google App Engine
This is Rietveld 408576698