Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 255086: GTK: Draw bottom-aligned ntp themes on floating bookmark bar.... (Closed)

Created:
11 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony, Miranda Callahan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

GTK: Draw bottom-aligned ntp themes on floating bookmark bar. This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well. I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907 BUG=22836 TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes.

Patch Set 1 #

Total comments: 4

Patch Set 2 : +comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -35 lines) Patch
M chrome/browser/gtk/bookmark_bar_gtk.cc View 4 chunks +28 lines, -35 lines 0 comments Download
A chrome/browser/ntp_background_util.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ntp_background_util.cc View 1 1 chunk +79 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
11 years, 2 months ago (2009-10-06 01:01:53 UTC) #1
tony
LG, but I'm curious about the use of skia. http://codereview.chromium.org/255086/diff/1/3 File chrome/browser/gtk/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/255086/diff/1/3#newcode1063 Line ...
11 years, 2 months ago (2009-10-06 01:24:21 UTC) #2
Miranda Callahan
This is really nice, lgtm. On 2009/10/06 01:24:21, tony wrote: > LG, but I'm curious ...
11 years, 2 months ago (2009-10-06 15:34:44 UTC) #3
Evan Stade
updated http://codereview.chromium.org/255086/diff/1/3 File chrome/browser/gtk/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/255086/diff/1/3#newcode1063 Line 1063: gfx::CanvasPaint canvas(event, true); On 2009/10/06 01:24:21, tony ...
11 years, 2 months ago (2009-10-06 18:43:57 UTC) #4
tony
11 years, 2 months ago (2009-10-06 18:54:39 UTC) #5
Ok, LGTM.

Powered by Google App Engine
This is Rietveld 408576698