GTK: Draw bottom-aligned ntp themes on floating bookmark bar....

GTK: Draw bottom-aligned ntp themes on floating bookmark bar.

This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well.

I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907

BUG=22836
TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes.

[tony, 2009-10-06 01:24:21]

LG, but I'm curious about the use of skia.

http://codereview.chromium.org/255086/diff/1/3
File chrome/browser/gtk/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/255086/diff/1/3#newcode1063
Line 1063: gfx::CanvasPaint canvas(event, true);
Is there a benefit to using Skia here rather than using cairo?  I guess to avoid
doing the conversion of an SkBitmap to a GDK pixbuf?

http://codereview.chromium.org/255086/diff/1/2
File chrome/browser/ntp_background_util.h (right):

http://codereview.chromium.org/255086/diff/1/2#newcode17
Line 17: static void PaintBackgroundDetachedMode(
Nit: Comment for this method.  Maybe a short comment for the class too?

[Miranda Callahan, 2009-10-06 15:34:44]

This is really nice, lgtm.

On 2009/10/06 01:24:21, tony wrote:
> LG, but I'm curious about the use of skia.
> 
> http://codereview.chromium.org/255086/diff/1/3
> File chrome/browser/gtk/bookmark_bar_gtk.cc (right):
> 
> http://codereview.chromium.org/255086/diff/1/3#newcode1063
> Line 1063: gfx::CanvasPaint canvas(event, true);
> Is there a benefit to using Skia here rather than using cairo?  I guess to
avoid
> doing the conversion of an SkBitmap to a GDK pixbuf?
> 
> http://codereview.chromium.org/255086/diff/1/2
> File chrome/browser/ntp_background_util.h (right):
> 
> http://codereview.chromium.org/255086/diff/1/2#newcode17
> Line 17: static void PaintBackgroundDetachedMode(
> Nit: Comment for this method.  Maybe a short comment for the class too?

[Evan Stade, 2009-10-06 18:43:57]

updated

http://codereview.chromium.org/255086/diff/1/3
File chrome/browser/gtk/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/255086/diff/1/3#newcode1063
Line 1063: gfx::CanvasPaint canvas(event, true);
On 2009/10/06 01:24:21, tony wrote:
> Is there a benefit to using Skia here rather than using cairo?  I guess to
avoid
> doing the conversion of an SkBitmap to a GDK pixbuf?

because I want to share code with windows. The code is rather hairy and given to
brokeness on corner cases.

http://codereview.chromium.org/255086/diff/1/2
File chrome/browser/ntp_background_util.h (right):

http://codereview.chromium.org/255086/diff/1/2#newcode17
Line 17: static void PaintBackgroundDetachedMode(
On 2009/10/06 01:24:21, tony wrote:
> Nit: Comment for this method.  Maybe a short comment for the class too?

Done.

[tony, 2009-10-06 18:54:39]

Ok, LGTM.