Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2550803002: WebVR: avoid race conditions for partially-initialized display (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

WebVR: avoid race conditions for partially-initialized display The GvrNonPresentingDelegate was acting as a pseudo VRDisplay device and reporting successful requestPresent even though vital information such as render resolution is not available yet. Instead of the "fallback" 2048x1024 resolution, report a 0x0 resolution so that other code can recognize this as an invalid device and defer actions such as resizing. One specific issue was that a vrpresentchange was getting fired prematurely, leading to wrong canvas sizing by the JS application. BUG=667327 Review-Url: https://codereview.chromium.org/2544713002 Cr-Commit-Position: refs/heads/master@{#435824} (cherry picked from commit 772bdaaac52114f3ebbc7626a3c630a3918b03d0) Committed: https://chromium.googlesource.com/chromium/src/+/578a9ee9e7c36be402e089e9dd83d97546752827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 5 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bajones
4 years ago (2016-12-02 21:46:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
578a9ee9e7c36be402e089e9dd83d97546752827.

Powered by Google App Engine
This is Rietveld 408576698