Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2550793002: Update expectations for --enable-slimming-paint-v2 (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
Xianzhu, trchen
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update expectations for --enable-slimming-paint-v2 27 new failures, 12 new passes. I haven't investigated which changes caused these, but the new failures are all minor subpixel issues. Committed: https://crrev.com/fc73ea738e9c7cddeebe98dfdbf50f449cbcd923 Cr-Commit-Position: refs/heads/master@{#436125}

Patch Set 1 #

Patch Set 2 : Update failure line #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 10 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
pdr.
4 years ago (2016-12-02 21:30:24 UTC) #3
Xianzhu
lgtm.
4 years ago (2016-12-02 21:37:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550793002/20001
4 years ago (2016-12-02 23:49:31 UTC) #11
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-03 00:00:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550793002/40001
4 years ago (2016-12-03 00:04:38 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-03 01:27:12 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-03 01:28:35 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc73ea738e9c7cddeebe98dfdbf50f449cbcd923
Cr-Commit-Position: refs/heads/master@{#436125}

Powered by Google App Engine
This is Rietveld 408576698