Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2550773002: [ios] Adds icons, overscroll and qrscanner resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds icons, overscroll and qrscanner resources BUG=666732 Committed: https://crrev.com/3306e88cd2d42e8a99b358ce25263c63d8bcda13 Cr-Commit-Position: refs/heads/master@{#436068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
A ios/chrome/browser/ui/icons/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_arrow_back.imageset/ic_arrow_back_3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_chevron_right.imageset/ic_chevron_right_3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_close.imageset/ic_close_3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_info.imageset/ic_info_3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/icons/resources/Icons.xcassets/ic_search.imageset/ic_search_3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_close_active@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_new_tab_active@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/overscroll_actions/resources/ptr_reload_active@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/Contents.json View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_off.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_off.imageset/torch_off.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_off.imageset/torch_off@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_off.imageset/torch_off@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_on.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_on.imageset/torch_on.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_on.imageset/torch_on@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/qr_scanner_torch_on.imageset/torch_on@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/Contents.json View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@3x.png View Binary file 0 comments Download

Messages

Total messages: 9 (4 generated)
sczs1
PTAL
4 years ago (2016-12-02 21:11:42 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 21:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550773002/1
4 years ago (2016-12-02 21:17:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 23:06:35 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 23:10:44 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3306e88cd2d42e8a99b358ce25263c63d8bcda13
Cr-Commit-Position: refs/heads/master@{#436068}

Powered by Google App Engine
This is Rietveld 408576698