Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2550703002: Move pending state from FullscreenController to Fullscreen (Closed)
Patch Set: tests and documentation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 380943d4bd35d176f42aaf4746e2d270e45c48ab..04287ea19f3345b23decf62a671c14ae4283668f 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -7816,9 +7816,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenNestedExit) {
webViewImpl->updateAllLifecyclePhases();
// We should now have fully exited fullscreen.
- // TODO(foolip): The top document's currentFullScreenElement is left
- // unchanged, leaving the page in a strange state. https://crbug.com/552541
- EXPECT_EQ(topBody, Fullscreen::currentFullScreenElementFrom(*topDoc));
+ EXPECT_EQ(nullptr, Fullscreen::currentFullScreenElementFrom(*topDoc));
EXPECT_EQ(nullptr, Fullscreen::fullscreenElementFrom(*topDoc));
EXPECT_EQ(nullptr, Fullscreen::currentFullScreenElementFrom(*iframeDoc));
EXPECT_EQ(nullptr, Fullscreen::fullscreenElementFrom(*iframeDoc));

Powered by Google App Engine
This is Rietveld 408576698