Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.h

Issue 2550703002: Move pending state from FullscreenController to Fullscreen (Closed)
Patch Set: tests and documentation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.h
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.h b/third_party/WebKit/Source/core/dom/Fullscreen.h
index 379e1f3e25ed2914b9c5be0401ad7f7d3d89f411..f14a4b628374aa9fe36484277804bb323d3e62f7 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.h
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.h
@@ -43,8 +43,8 @@
namespace blink {
-class LayoutFullScreen;
class ComputedStyle;
+class LayoutFullScreen;
class CORE_EXPORT Fullscreen final
: public GarbageCollectedFinalized<Fullscreen>,
@@ -92,7 +92,9 @@ class CORE_EXPORT Fullscreen final
: nullptr;
}
- void didEnterFullscreenForElement(Element*);
+ // Called by FullscreenController to notify that we've entered or exited
+ // fullscreen. All frames are notified, so there may be no pending request.
+ void didEnterFullscreen();
void didExitFullscreen();
void setFullScreenLayoutObject(LayoutFullScreen*);
@@ -137,6 +139,7 @@ class CORE_EXPORT Fullscreen final
void enqueueErrorEvent(Element&, RequestType);
void eventQueueTimerFired(TimerBase*);
+ Member<Element> m_pendingFullscreenElement;
HeapVector<std::pair<Member<Element>, RequestType>> m_fullscreenElementStack;
Member<Element> m_currentFullScreenElement;
LayoutFullScreen* m_fullScreenLayoutObject;

Powered by Google App Engine
This is Rietveld 408576698