Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 25507008: Add setting for disabling compositor touch hit testing (Closed)

Created:
7 years, 2 months ago by Rick Byers
Modified:
7 years, 2 months ago
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dglazkov+blink, jamesr, abarth-chromium
Visibility:
Public.

Description

Add setting for disabling compositor touch hit testing BUG=303945 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158956

Patch Set 1 #

Patch Set 2 : Disable hit testing setting - add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
A LayoutTests/fast/events/touch/compositor-touch-hit-rects-disabled.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/touch/compositor-touch-hit-rects-disabled-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rick Byers
Levi, Please review the blink side of this change. I'll have to wait for it ...
7 years, 2 months ago (2013-10-04 02:07:48 UTC) #1
Rick Byers
On 2013/10/04 02:07:48, Rick Byers wrote: > Levi, > Please review the blink side of ...
7 years, 2 months ago (2013-10-04 04:37:19 UTC) #2
darin (slow to review)
On 2013/10/04 04:37:19, Rick Byers wrote: > On 2013/10/04 02:07:48, Rick Byers wrote: > > ...
7 years, 2 months ago (2013-10-04 15:54:25 UTC) #3
leviw_travelin_and_unemployed
LGTM.
7 years, 2 months ago (2013-10-04 18:14:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/25507008/3001
7 years, 2 months ago (2013-10-04 18:14:52 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 22:25:55 UTC) #6
Message was sent while issue was closed.
Change committed as 158956

Powered by Google App Engine
This is Rietveld 408576698