[stubs] Cleanup usages of CSA::Select().

src/builtins/builtins-regexp.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins-utils.h"
 #include "src/builtins/builtins.h"
 
 #include "src/code-factory.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/regexp-utils.h"
@@ skipping 896 matching lines @@
   Node* const receiver_map = a->LoadMap(receiver);
   Node* const instance_type = a->LoadMapInstanceType(receiver_map);
 
   a->Branch(a->Word32Equal(instance_type, a->Int32Constant(JS_REGEXP_TYPE)),
             &if_isunmodifiedjsregexp, &if_isnotunmodifiedjsregexp);
 
   a->Bind(&if_isunmodifiedjsregexp);
   {
     // Refer to JSRegExp's flag property on the fast-path.
     Node* const is_flag_set = FastFlagGetter(a, receiver, flag);
-    a->Return(a->Select(is_flag_set, a->TrueConstant(), a->FalseConstant()));
+    a->Return(a->SelectBooleanConstant(is_flag_set));
   }
 
   a->Bind(&if_isnotunmodifiedjsregexp);
   {
     Node* const native_context = a->LoadNativeContext(context);
     Node* const regexp_fun =
         a->LoadContextElement(native_context, Context::REGEXP_FUNCTION_INDEX);
     Node* const initial_map = a->LoadObjectField(
         regexp_fun, JSFunction::kPrototypeOrInitialMapOffset);
     Node* const initial_prototype = a->LoadMapPrototype(initial_map);
@@ skipping 257 matching lines @@
     a.Bind(&if_didnotmatch);
     a.Return(a.FalseConstant());
   }
 
   a.Bind(&slow_path);
   {
     // Call exec.
     Node* const match_indices = RegExpExec(&a, context, receiver, string);
 
     // Return true iff exec matched successfully.
-    Node* const result = a.Select(a.WordEqual(match_indices, a.NullConstant()),
-                                  a.FalseConstant(), a.TrueConstant());
+    Node* const result = a.SelectBooleanConstant(
+        a.WordNotEqual(match_indices, a.NullConstant()));

[Igor Sheludko, 2016/12/05 08:48:49]

Note: negated condition.

     a.Return(result);
   }
 }
 
 namespace {
 
 Node* AdvanceStringIndex(CodeStubAssembler* a, Node* const string,
                          Node* const index, Node* const is_unicode) {
   CVariable var_result(a, MachineRepresentation::kTagged);
 
@@ skipping 1233 matching lines @@
   a.Bind(&if_matched);
   {
     Node* result = ConstructNewResultFromMatchInfo(isolate, &a, context,
                                                    match_indices, string);
     a.Return(result);
   }
 }
 
 }  // namespace internal
 }  // namespace v8