On 2016/12/02 16:52:51, stevenjb wrote:
> RS LGTM (unless there is a specific area you would like me to double check).
> Typically straightforward merges can use TBR=original-reviewer.
BTW, is there an expected difference in how the Android settings app behaves
when launched with ui::EF_LEFT_MOUSE_BUTTON vs ui::EF_NONE? I added you to
https://codereview.chromium.org/2541923002/ to look at the implementation for MD
Settings.
On 2016/12/02 16:56:12, stevenjb wrote:
> On 2016/12/02 16:52:51, stevenjb wrote:
> > RS LGTM (unless there is a specific area you would like me to double check).
> > Typically straightforward merges can use TBR=original-reviewer.
>
> BTW, is there an expected difference in how the Android settings app behaves
> when launched with ui::EF_LEFT_MOUSE_BUTTON vs ui::EF_NONE? I added you to
> https://codereview.chromium.org/2541923002/ to look at the implementation for
MD
> Settings.
Yes, when launched with ui::EF_LEFT_MOUSE_BUTTON it should enter touch mode. For
the settings app the only noticeable differecen AFAICT is that when it's out of
touch mode (when launched with ui::EF_NONE) it should show focus around one
element, to hint that it's navigable with the keyboard.
Luis Héctor Chávez
Description was changed from ========== [Merge to 2924] Reland "Propagate information about how ARC apps ...
Issue 2550683002: [Merge to 2924] Reland "Propagate information about how ARC apps are launched"
(Closed)
Created 4 years ago by Luis Héctor Chávez
Modified 4 years ago
Reviewers: stevenjb
Base URL:
Comments: 0