Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2550663003: Fix arm library path for nacl tests (Closed)

Created:
4 years ago by Sam Clegg
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix arm library path for nacl tests With this change linux_arm bot now gets past the isolate_tests phase and fails when trying to run the tests on swarming. BUG=564059 Committed: https://crrev.com/e1e756db7c44f44ce809170d12865341cb6c1ad5 Cr-Commit-Position: refs/heads/master@{#436375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/nacl/rules.gni View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Sam Clegg
4 years ago (2016-12-02 21:04:42 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-12-02 22:41:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550663003/1
4 years ago (2016-12-05 18:17:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 19:51:54 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-05 19:53:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1e756db7c44f44ce809170d12865341cb6c1ad5
Cr-Commit-Position: refs/heads/master@{#436375}

Powered by Google App Engine
This is Rietveld 408576698