Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2550633002: Convert editing/execCommand/format-block-contenteditable-false.html to utilize w3c test harness (Closed)

Created:
4 years ago by yosin_UTC9
Modified:
4 years ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/execCommand/format-block-contenteditable-false.html to utilize w3c test harness This patch converts "format-block-converts-false.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is as preparation of http://crrev.com/2532373002 BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/6a123e7ba0e8bf847d270b8e76d6aa1e35b972dc Cr-Commit-Position: refs/heads/master@{#436226}

Patch Set 1 : 2016-12-02T15:40:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/editing/execCommand/format-block-contenteditable-false.html View 1 chunk +28 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/format-block-contenteditable-false-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years ago (2016-12-02 09:03:54 UTC) #7
Xiaocheng
lgtm
4 years ago (2016-12-05 02:24:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550633002/1
4 years ago (2016-12-05 02:24:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 03:28:22 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 03:30:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a123e7ba0e8bf847d270b8e76d6aa1e35b972dc
Cr-Commit-Position: refs/heads/master@{#436226}

Powered by Google App Engine
This is Rietveld 408576698