Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255063002: copy the pica benchmark to polymer_load (Closed)

Created:
6 years, 7 months ago by ykyyip
Modified:
6 years, 7 months ago
Reviewers:
dtu, tonyg, adamk
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

copy the pica benchmark to polymer_load Rename the pica benchmark to something more generic to reuse with other page sets. The pica benchmark will be removed after it's also renamed in the perf bot. R=dtu@chromium.org,adamk@chromium.org,tonyg@chromium.org NOTRY=true

Patch Set 1 #

Patch Set 2 : fix presubmit #

Patch Set 3 : add NOTRY=true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -15 lines) Patch
M tools/perf/benchmarks/pica.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/perf/benchmarks/polymer_load.py View 1 chunk +13 lines, -0 lines 0 comments Download
A tools/perf/measurements/polymer_load.py View 1 1 chunk +37 lines, -0 lines 0 comments Download
M tools/perf/page_sets/pica.py View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ykyyip
Can you PTAL?
6 years, 7 months ago (2014-04-28 22:55:36 UTC) #1
adamk
lgtm The rename sounds like a great idea to me.
6 years, 7 months ago (2014-04-28 22:57:06 UTC) #2
dtu
lgtm
6 years, 7 months ago (2014-04-28 23:51:01 UTC) #3
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 7 months ago (2014-04-28 23:51:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/255063002/1
6 years, 7 months ago (2014-04-28 23:52:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:27:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 00:27:47 UTC) #7
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 7 months ago (2014-04-29 19:02:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/255063002/20001
6 years, 7 months ago (2014-04-29 19:03:15 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 19:56:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 19:56:17 UTC) #11
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 7 months ago (2014-04-29 19:57:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/255063002/20001
6 years, 7 months ago (2014-04-29 19:58:47 UTC) #13
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 7 months ago (2014-04-29 20:02:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/255063002/40001
6 years, 7 months ago (2014-04-29 20:05:20 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 20:37:48 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 20:37:49 UTC) #17 
Failed to apply patch for tools/perf/benchmarks/pica.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/benchmarks/pica.py
  Hunk #1 FAILED at 12.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/perf/benchmarks/pica.py.rej

Patch:       tools/perf/benchmarks/pica.py
Index: tools/perf/benchmarks/pica.py
diff --git a/tools/perf/benchmarks/pica.py b/tools/perf/benchmarks/pica.py
index
98b316e6244631f947632eb9f26a6b3591afbad3..f5cef99eb509b52750d2a0be8a2def8625ca0126
100644
--- a/tools/perf/benchmarks/pica.py
+++ b/tools/perf/benchmarks/pica.py
@@ -12,7 +12,7 @@ class _PicaMeasurement(page_measurement.PageMeasurement):
         '--enable-experimental-web-platform-features')
 
   def MeasurePage(self, _, tab, results):
-    result = int(tab.EvaluateJavaScript('__pica_load_time'))
+    result = int(tab.EvaluateJavaScript('__polymer_ready_time'))
     results.Add('Total', 'ms', result)

Powered by Google App Engine
This is Rietveld 408576698