Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2550623002: Add MemoryCoordinator::GetGlobalMemoryState() (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MemoryCoordinator::GetGlobalMemoryState() MemoryCoordinator::GetCurrentMemoryState() is not always the same as the global memory state because the browser process won't be suspended (at least for now). On the other hand, we want to have a way to record the global memory state to tweak memory coordinator's parameters. Add GetGlobalMemoryState() method which returns the raw value of the global state. Keep GetCurrentMemoryState() for clients in the browser process. BUG=662772 Committed: https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b Cr-Commit-Position: refs/heads/master@{#435873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M content/browser/memory/memory_coordinator.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
bashi
PTAL I noticed that we don't record SUSPENDED state correctly :(
4 years ago (2016-12-02 05:47:28 UTC) #4
haraken
LGTM Maybe it's worth renaming CurrentMemoryState to LocalMemoryState for clarity.
4 years ago (2016-12-02 05:55:35 UTC) #5
bashi
On 2016/12/02 05:55:35, haraken wrote: > LGTM > > Maybe it's worth renaming CurrentMemoryState to ...
4 years ago (2016-12-02 05:59:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550623002/1
4 years ago (2016-12-02 06:00:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 07:06:10 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 07:08:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e2c875dca161e2b897d4cf454633c424b52f55b
Cr-Commit-Position: refs/heads/master@{#435873}

Powered by Google App Engine
This is Rietveld 408576698