Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2550613002: [ios] Adds ui resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds ui resources BUG=666732 Committed: https://crrev.com/1cb9dd8212ed53dda879d61829cea001b7948249 Cr-Commit-Position: refs/heads/master@{#436005}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove visibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice@2x~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice_pressed@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice_pressed@2x~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice_pressed@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice_pressed~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/custom_row_voice~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon_incognito.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon_incognito@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/default_favicon_incognito@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_bg_portrait_tablet.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_button.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_button@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_button@2x~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_button@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/resources/keyboard_button~ipad.png View Binary file 0 comments Download

Messages

Total messages: 16 (9 generated)
sczs1
PTAL and CQ if it lgty
4 years ago (2016-12-02 03:33:10 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 17:18:14 UTC) #7
rohitrao (ping after 24h)
https://codereview.chromium.org/2550613002/diff/1/ios/chrome/browser/ui/BUILD.gn File ios/chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2550613002/diff/1/ios/chrome/browser/ui/BUILD.gn#newcode87 ios/chrome/browser/ui/BUILD.gn:87: visibility = [ ":ui" ] Can you remove the ...
4 years ago (2016-12-02 17:19:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550613002/20001
4 years ago (2016-12-02 18:56:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 20:10:10 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1cb9dd8212ed53dda879d61829cea001b7948249 Cr-Commit-Position: refs/heads/master@{#436005}
4 years ago (2016-12-02 20:12:57 UTC) #15
sdefresne
4 years ago (2016-12-05 14:59:32 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698