Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/wm/core/shadow_unittest.cc

Issue 2550593002: Update WM shadows for MD. (Closed)
Patch Set: fix border for small windows Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/wm/core/shadow.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/wm/core/shadow_unittest.cc
diff --git a/ui/wm/core/shadow_unittest.cc b/ui/wm/core/shadow_unittest.cc
index b376262b0e2e741f5eaf433f3a0177514d5ecc5f..7416c39594fb996230c639ba2702f53e0b36f7db 100644
--- a/ui/wm/core/shadow_unittest.cc
+++ b/ui/wm/core/shadow_unittest.cc
@@ -4,145 +4,42 @@
#include "ui/wm/core/shadow.h"
-#include <memory>
-
#include "base/macros.h"
-#include "base/path_service.h"
-#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/aura/test/aura_test_base.h"
-#include "ui/aura/test/test_windows.h"
-#include "ui/aura/window.h"
-#include "ui/base/resource/resource_bundle.h"
-#include "ui/base/ui_base_paths.h"
-#include "ui/compositor/layer.h"
-#include "ui/compositor/layer_tree_owner.h"
-#include "ui/resources/grit/ui_resources.h"
namespace wm {
-
namespace {
-const int kSmallBitmapSize = 129;
-const int kLargeBitmapSize = 269;
-
-// Mock for the ResourceBundle::Delegate class.
-class MockResourceBundleDelegate : public ui::ResourceBundle::Delegate {
- public:
- MockResourceBundleDelegate() : last_resource_id_(0) {
- SkBitmap bitmap_small, bitmap_large;
- bitmap_small.allocPixels(
- SkImageInfo::MakeN32Premul(kSmallBitmapSize, kSmallBitmapSize));
- bitmap_large.allocPixels(
- SkImageInfo::MakeN32Premul(kLargeBitmapSize, kLargeBitmapSize));
- image_small_ = gfx::Image::CreateFrom1xBitmap(bitmap_small);
- image_large_ = gfx::Image::CreateFrom1xBitmap(bitmap_large);
- }
- ~MockResourceBundleDelegate() override {}
-
- // ResourceBundle::Delegate:
- base::FilePath GetPathForResourcePack(const base::FilePath& pack_path,
- ui::ScaleFactor scale_factor) override {
- return base::FilePath();
- }
- base::FilePath GetPathForLocalePack(const base::FilePath& pack_path,
- const std::string& locale) override {
- return base::FilePath();
- }
- gfx::Image GetImageNamed(int resource_id) override {
- last_resource_id_ = resource_id;
- switch (resource_id) {
- case IDR_WINDOW_BUBBLE_SHADOW_SMALL:
- return image_small_;
- case IDR_AURA_SHADOW_ACTIVE:
- case IDR_AURA_SHADOW_INACTIVE:
- return image_large_;
- default:
- NOTREACHED();
- return gfx::Image();
- }
- }
- gfx::Image GetNativeImageNamed(int resource_id) override {
- return gfx::Image();
- }
- base::RefCountedStaticMemory* LoadDataResourceBytes(
- int resource_id,
- ui::ScaleFactor scale_factor) override {
- return NULL;
- }
- bool GetRawDataResource(int resource_id,
- ui::ScaleFactor scale_factor,
- base::StringPiece* value) override {
- return false;
- }
- bool GetLocalizedString(int message_id, base::string16* value) override {
- return false;
- }
-
- int last_resource_id() const { return last_resource_id_; }
-
- private:
- gfx::Image image_small_;
- gfx::Image image_large_;
- int last_resource_id_;
-
- DISALLOW_COPY_AND_ASSIGN(MockResourceBundleDelegate);
-};
-
-} // namespace
-
-class ShadowTest: public aura::test::AuraTestBase {
- public:
- ShadowTest() {}
- ~ShadowTest() override {}
-
- MockResourceBundleDelegate* delegate() { return delegate_.get(); }
-
- // aura::testAuraBase:
- void SetUp() override {
- aura::test::AuraTestBase::SetUp();
- delegate_.reset(new MockResourceBundleDelegate());
- if (ResourceBundle::HasSharedInstance())
- ui::ResourceBundle::CleanupSharedInstance();
- ui::ResourceBundle::InitSharedInstanceWithLocale(
- "en-US", delegate(), ui::ResourceBundle::LOAD_COMMON_RESOURCES);
- }
- void TearDown() override {
- ui::ResourceBundle::CleanupSharedInstance();
- base::FilePath ui_test_pak_path;
- ASSERT_TRUE(PathService::Get(ui::UI_TEST_PAK, &ui_test_pak_path));
- ui::ResourceBundle::InitSharedInstanceWithPakPath(ui_test_pak_path);
- aura::test::AuraTestBase::TearDown();
- }
- private:
- std::unique_ptr<MockResourceBundleDelegate> delegate_;
- DISALLOW_COPY_AND_ASSIGN(ShadowTest);
-};
-
-// Test if the proper image is set for the specified style.
-TEST_F(ShadowTest, UpdateImagesForStyle) {
- Shadow shadow;
-
- shadow.Init(Shadow::STYLE_SMALL);
- EXPECT_EQ(delegate()->last_resource_id(), IDR_WINDOW_BUBBLE_SHADOW_SMALL);
- shadow.SetStyle(Shadow::STYLE_ACTIVE);
- EXPECT_EQ(delegate()->last_resource_id(), IDR_AURA_SHADOW_ACTIVE);
- shadow.SetStyle(Shadow::STYLE_INACTIVE);
- EXPECT_EQ(delegate()->last_resource_id(), IDR_AURA_SHADOW_INACTIVE);
-}
+using ShadowTest = aura::test::AuraTestBase;
// Test if the proper content bounds is calculated based on the current style.
TEST_F(ShadowTest, SetContentBounds) {
+ // Verify that layer bounds are outset from content bounds.
Shadow shadow;
-
- // Verify that layer bounds are inset from content bounds.
- shadow.Init(Shadow::STYLE_ACTIVE);
- gfx::Rect content_bounds(100, 100, 300, 300);
- shadow.SetContentBounds(content_bounds);
- EXPECT_EQ(shadow.content_bounds(), content_bounds);
- EXPECT_EQ(shadow.layer()->bounds(), gfx::Rect(36, 36, 428, 428));
-
- shadow.SetStyle(Shadow::STYLE_SMALL);
- EXPECT_EQ(shadow.content_bounds(), content_bounds);
- EXPECT_EQ(shadow.layer()->bounds(), gfx::Rect(96, 96, 308, 308));
+ {
+ shadow.Init(Shadow::STYLE_ACTIVE);
+ gfx::Rect content_bounds(100, 100, 300, 300);
+ shadow.SetContentBounds(content_bounds);
+ EXPECT_EQ(content_bounds, shadow.content_bounds());
+ gfx::Rect shadow_bounds(content_bounds);
+ int elevation = 24;
+ shadow_bounds.Inset(-gfx::Insets(2 * elevation) +
+ gfx::Insets(elevation, 0, -elevation, 0));
+ EXPECT_EQ(shadow_bounds, shadow.layer()->bounds());
+ }
+
+ {
+ shadow.SetStyle(Shadow::STYLE_SMALL);
+ gfx::Rect content_bounds(100, 100, 300, 300);
+ shadow.SetContentBounds(content_bounds);
+ EXPECT_EQ(content_bounds, shadow.content_bounds());
+ gfx::Rect shadow_bounds(content_bounds);
+ int elevation = 6;
+ shadow_bounds.Inset(-gfx::Insets(2 * elevation) +
+ gfx::Insets(elevation, 0, -elevation, 0));
+ EXPECT_EQ(shadow_bounds, shadow.layer()->bounds());
+ }
}
+
+} // namespace
} // namespace wm
« no previous file with comments | « ui/wm/core/shadow.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698