Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2550543002: Kill off fpdf_render_cache.cpp (Closed)

Created:
4 years ago by npm
Modified:
4 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -553 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
A core/fpdfapi/render/cpdf_imagecacheentry.h View 1 chunk +71 lines, -0 lines 0 comments Download
A + core/fpdfapi/render/cpdf_imagecacheentry.cpp View 6 chunks +15 lines, -165 lines 0 comments Download
M core/fpdfapi/render/cpdf_imageloader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/render/cpdf_pagerendercache.h View 1 1 chunk +9 lines, -21 lines 0 comments Download
A core/fpdfapi/render/cpdf_pagerendercache.cpp View 1 chunk +143 lines, -0 lines 0 comments Download
D core/fpdfapi/render/fpdf_render_cache.cpp View 1 chunk +0 lines, -316 lines 0 comments Download
M core/fpdfapi/render/render_int.h View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
npm
ptal
4 years ago (2016-12-01 23:07:59 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-01 23:16:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550543002/1
4 years ago (2016-12-01 23:17:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/3044)
4 years ago (2016-12-01 23:18:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550543002/20001
4 years ago (2016-12-01 23:23:55 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 23:37:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d7ecb5f272de6cdd88ecef4c7b4d0dbee435...

Powered by Google App Engine
This is Rietveld 408576698