Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2550533002: Revert of Reenable Tabdragging tests failing because of IsWindowPositionManaged() (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable Tabdragging tests failing because of IsWindowPositionManaged() (patchset #10 id:200001 of https://codereview.chromium.org/2494713003/ ) Reason for revert: Causing failures in ash_unittests. See CL comments for details. If you have a fix, please reland with the fix applied. Original issue's description: > Reenable Tabdragging tests failing because of IsWindowPositionManaged() > > It used to be exiting the move loop and clearing the move_loop_widget_ before > EndDrag() had a chance to set the window position to manageable again. > > This CL adds a maximized browser window waiter, and moves setting the window > position managed logic to ash. > > BUG=626761, 331924 > TEST=interactive_ui_tests --gtest_filter=TabDragging* > > Committed: https://crrev.com/c813d7634e5c6ba6c808e326778b0cdb4f6e773c > Cr-Commit-Position: refs/heads/master@{#435638} TBR=pkasting@chromium.org,sky@chromium.org,skuhne@chromium.org,erg@chromium.org,afakhry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626761, 331924 Committed: https://crrev.com/3a9a59b140a23a82da474ede5c5abb311bb088c1 Cr-Commit-Position: refs/heads/master@{#435742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -131 lines) Patch
M ash/wm/toplevel_window_event_handler.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 9 chunks +34 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 8 chunks +15 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of Reenable Tabdragging tests failing because of IsWindowPositionManaged()
4 years ago (2016-12-01 22:38:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550533002/1
4 years ago (2016-12-01 22:39:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 22:40:29 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 22:43:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9a59b140a23a82da474ede5c5abb311bb088c1
Cr-Commit-Position: refs/heads/master@{#435742}

Powered by Google App Engine
This is Rietveld 408576698