Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 255053002: chrome.bluetoothLowEnergy: Implement getCharacteristics. (Closed)

Created:
6 years, 7 months ago by armansito
Modified:
6 years, 7 months ago
Reviewers:
keybuk, rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

chrome.bluetoothLowEnergy: Implement getCharacteristics. This CL implements the getCharacteristics method of the bluetoothLowEnergy API and adds a mapping for Characteristic instance IDs to BluetoothLowEnergyEventRouter. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268009

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added TODO referencing crbug.com/368368. #

Patch Set 3 : #

Messages

Total messages: 12 (0 generated)
armansito
6 years, 7 months ago (2014-04-28 22:02:16 UTC) #1
rpaquay
lgtm https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc (right): https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc#newcode44 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:44: // because Characteristic contains a list of enum ...
6 years, 7 months ago (2014-04-29 17:38:30 UTC) #2
armansito
https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc (right): https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc#newcode44 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:44: // because Characteristic contains a list of enum CharacteristicProperty. ...
6 years, 7 months ago (2014-04-29 19:31:18 UTC) #3
rpaquay
https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc (right): https://codereview.chromium.org/255053002/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc#newcode44 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:44: // because Characteristic contains a list of enum CharacteristicProperty. ...
6 years, 7 months ago (2014-04-29 19:33:11 UTC) #4
keybuk
lgtm
6 years, 7 months ago (2014-04-30 16:29:47 UTC) #5
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-02 22:24:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/255053002/40001
6 years, 7 months ago (2014-05-02 22:25:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 23:34:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 23:34:04 UTC) #9
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-03 00:01:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/255053002/40001
6 years, 7 months ago (2014-05-03 00:02:21 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:25:26 UTC) #12
Message was sent while issue was closed.
Change committed as 268009

Powered by Google App Engine
This is Rietveld 408576698