Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2550513002:
Fix TestExpectations in preparation for a V8 CL (Closed)
DescriptionFix TestExpectations in preparation for a V8 CL
A separate V8 CL was introduced and reverted, which was supposed to use
parenthesis instead of square brackets in descriptions
https://codereview.chromium.org/2530803002/
This CL fixes the test expectations so that Blink layout tests should not fail
when that V8 CL is re-landed.
https://codereview.chromium.org/2521853003/
Committed: https://crrev.com/04ddd1bce9c37ea8e3dbc26e0d75e06a26c16f12
Cr-Commit-Position: refs/heads/master@{#435762}
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Description was changed from ========== Fix test expectations ========== to ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions (https://codereview.chromium.org/2530803002/). This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. ==========
luoe@chromium.org changed reviewers: + kozyatinskiy@chromium.org
I've patched in the injected script source change into a tip of tree checkout and run the inspector tests. PTAL
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions (https://codereview.chromium.org/2530803002/). This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. ========== to ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2546873002/ ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2546873002/ ========== to ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2521853003/ ==========
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480634833179060, "parent_rev":
"0088f62e20b786096034a2dd342488358a7da255", "commit_rev":
"be23de339b86176a5c1bb634c72d7549724c0c59"}
Message was sent while issue was closed.
Description was changed from ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2521853003/ ========== to ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2521853003/ ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2521853003/ ========== to ========== Fix TestExpectations in preparation for a V8 CL A separate V8 CL was introduced and reverted, which was supposed to use parenthesis instead of square brackets in descriptions https://codereview.chromium.org/2530803002/ This CL fixes the test expectations so that Blink layout tests should not fail when that V8 CL is re-landed. https://codereview.chromium.org/2521853003/ Committed: https://crrev.com/04ddd1bce9c37ea8e3dbc26e0d75e06a26c16f12 Cr-Commit-Position: refs/heads/master@{#435762} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/04ddd1bce9c37ea8e3dbc26e0d75e06a26c16f12 Cr-Commit-Position: refs/heads/master@{#435762} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
