MIPS: Port '[x86] Also deal with holey arrays in the Apply builtin.'

MIPS: Port '[x86] Also deal with holey arrays in the Apply builtin.'

Port of d4f01b8a65ec02250c3f2b52b9a5e335ff513d98

BUG=

Committed: https://crrev.com/46bf4c16cc5f0a91e591b824194f42b8c1a34ed7
Cr-Commit-Position: refs/heads/master@{#41474}

[Marija Antic, 2016-12-02 08:43:16]

marija.antic@imgtec.com changed reviewers:
+ dusan.simicic@imgtec.com, ilija.pavlovic@imgtec.com,
ivica.bogosavljevic@imgtec.com, miran.karic@imgtec.com, predrag.rudic@imgtec.com

[Marija Antic, 2016-12-02 08:43:16]

PTAL

[Ilija.Pavlovic1, 2016-12-02 10:32:51]

ilija.pavlovic@imgtec.com changed reviewers:
+ Ilija.Pavlovic@imgtec.com

[Ilija.Pavlovic1, 2016-12-02 10:32:52]

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
File src/builtins/mips/builtins-mips.cc (right):

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2180: __ bind(&create_holey_array);
Missing 
__ lw(a2, FieldMemOperand(a0, HeapObject::kMapOffset));
?

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2185: __ lw(a2, FieldMemOperand(t0,
PropertyCell::kValueOffset));
Maybe to change into 
__ LoadRoot(at, Heap::kArrayProtectorRootIndex);
__ lw(a2, FieldMemOperand(at, PropertyCell::kValueOffset));
?

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2188: __ lw(a2, FieldMemOperand(a0,
JSArray::kLengthOffset));
Maybe to change into 
__ lw(t0, FieldMemOperand(a0, JSArray::kLengthOffset));
?

[Marija Antic, 2016-12-02 11:48:07]

marija.antic@imgtec.com changed reviewers:
- Ilija.Pavlovic@imgtec.com

[Marija Antic, 2016-12-02 11:48:08]

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
File src/builtins/mips/builtins-mips.cc (right):

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2180: __ bind(&create_holey_array);
On 2016/12/02 10:32:52, Ilija.Pavlovic1 wrote:
> Missing 
> __ lw(a2, FieldMemOperand(a0, HeapObject::kMapOffset));
> ?

Value FieldMemOperand(a0, HeapObject::kMapOffset) is loaded into a2 in line
2139. Register a2 might be modified in line 2170, but we will jump to
&done_create afterwards, and never reach this point.
I was also considering arm port https://codereview.chromium.org/2537453003/.

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2185: __ lw(a2, FieldMemOperand(t0,
PropertyCell::kValueOffset));
On 2016/12/02 10:32:52, Ilija.Pavlovic1 wrote:
> Maybe to change into 
> __ LoadRoot(at, Heap::kArrayProtectorRootIndex);
> __ lw(a2, FieldMemOperand(at, PropertyCell::kValueOffset));
> ?

Done.

https://codereview.chromium.org/2550503003/diff/1/src/builtins/mips/builtins-...
src/builtins/mips/builtins-mips.cc:2188: __ lw(a2, FieldMemOperand(a0,
JSArray::kLengthOffset));
On 2016/12/02 10:32:52, Ilija.Pavlovic1 wrote:
> Maybe to change into 
> __ lw(t0, FieldMemOperand(a0, JSArray::kLengthOffset));
> ?

Length should be in a2 after we are finished (lines 2228-2232)

[ivica.bogosavljevic, 2016-12-02 15:33:05]

lgtm

[Marija Antic, 2016-12-05 07:17:51]

The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 07:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 07:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 07:42:54]

Dry run: This issue passed the CQ dry run.

[Marija Antic, 2016-12-05 07:43:24]

The CQ bit was checked by marija.antic@imgtec.com

[commit-bot: I haz the power, 2016-12-05 07:43:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 07:45:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480923804151080,
"parent_rev": "944eafce117efb2ec3d8ff3b0d49e3ec17424006", "commit_rev":
"693db427bd4afee3108511983031f5559764a082"}

[commit-bot: I haz the power, 2016-12-05 07:45:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 07:45:53]

Description was changed from

==========
MIPS: Port '[x86] Also deal with holey arrays in the Apply builtin.'

Port of d4f01b8a65ec02250c3f2b52b9a5e335ff513d98

BUG=
==========

to

==========
MIPS: Port '[x86] Also deal with holey arrays in the Apply builtin.'

Port of d4f01b8a65ec02250c3f2b52b9a5e335ff513d98

BUG=

Committed: https://crrev.com/46bf4c16cc5f0a91e591b824194f42b8c1a34ed7
Cr-Commit-Position: refs/heads/master@{#41474}
==========

[commit-bot: I haz the power, 2016-12-05 07:45:54]

Patchset 2 (id:??) landed as
https://crrev.com/46bf4c16cc5f0a91e591b824194f42b8c1a34ed7
Cr-Commit-Position: refs/heads/master@{#41474}