Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 25505007: Remove bogus use of the term "user style" in Blink and Blink API (Closed)

Created:
7 years, 2 months ago by adamk
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, ojan
Visibility:
Public.

Description

Remove bogus use of the term "user style" in Blink and Blink API The WebView::addUserStyleSheet() method in fact simply injects author styles into the page. I've deprecated that method and replaced it with an injectStyleSheet() method. Similar renaming has happened for the other levels of that codepath inside Blink (in PageGroup, StyleEngine, TestRunner). Also killed dead code supporting Page-level UserStyle injection, which isn't possible in Blink/Chromium. This patch makes no changes in behavior. R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158680

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -612 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/DocumentRuleSets.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 5 chunks +8 lines, -21 lines 0 comments Download
A + Source/core/page/InjectedStyleSheet.h View 1 chunk +12 lines, -25 lines 0 comments Download
M Source/core/page/PageGroup.h View 3 chunks +5 lines, -10 lines 0 comments Download
M Source/core/page/PageGroup.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
D Source/core/page/UserContentTypes.h View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/core/page/UserContentURLPattern.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/page/UserContentURLPattern.cpp View 1 chunk +0 lines, -234 lines 0 comments Download
D Source/core/page/UserStyleSheet.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/page/UserStyleSheetTypes.h View 1 chunk +0 lines, -42 lines 0 comments Download
A + Source/platform/URLPatternMatcher.h View 3 chunks +10 lines, -19 lines 0 comments Download
A + Source/platform/URLPatternMatcher.cpp View 6 chunks +17 lines, -35 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/testing/runner/TestRunner.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +12 lines, -13 lines 0 comments Download
M public/web/WebView.h View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
7 years, 2 months ago (2013-10-01 22:03:34 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-01 22:08:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/25505007/1
7 years, 2 months ago (2013-10-01 22:10:23 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/platform/blink_platform.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-01 23:30:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/25505007/14001
7 years, 2 months ago (2013-10-02 00:03:23 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-02 01:53:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/25505007/14001
7 years, 2 months ago (2013-10-02 03:32:58 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 03:33:37 UTC) #8
Message was sent while issue was closed.
Change committed as 158680

Powered by Google App Engine
This is Rietveld 408576698