Early out if contentviewcore native side is null.

Early out if contentviewcore native side is null.

BUG=b/10911057

Early out before calling native getNavigatonHistory as it may be
deleted before.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226361

[joth, 2013-10-01 18:52:06]

lgtm w/ 1 nit

https://codereview.chromium.org/25505005/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/25505005/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3047:
// TODO(sgurun) add a test case for b/10911057
nit: don't  put "b/10911057" in the comment in the code. Just say "add test case
to cover calling these methods after AwContents.destroy()"

Even better open a crbug for it.

[sgurun-gerrit only, 2013-10-01 19:04:41]

On 2013/10/01 18:52:06, joth wrote:
> lgtm w/ 1 nit
> 
>
https://codereview.chromium.org/25505005/diff/1/content/public/android/java/s...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/25505005/diff/1/content/public/android/java/s...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3047:
> // TODO(sgurun) add a test case for b/10911057
> nit: don't  put "b/10911057" in the comment in the code. Just say "add test
case
> to cover calling these methods after AwContents.destroy()"
> 
> Even better open a crbug for it.

done. created crbug 302689

[commit-bot: I haz the power, 2013-10-01 19:21:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/25505005/4001

[commit-bot: I haz the power, 2013-10-01 20:27:42]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-10-01 20:37:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/25505005/4001

[boliu, 2013-10-01 20:37:32]

https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3072:
return new String();
Maybe return "" is ehh......more efficient?

[boliu, 2013-10-01 20:38:16]

On 2013/10/01 20:37:32, boliu wrote:
>
https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3072:
> return new String();
> Maybe return "" is ehh......more efficient?

It's not a flake, rechecking cq is not going to do anything.

[sgurun-gerrit only, 2013-10-01 20:49:29]

https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/25505005/diff/4001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3072:
return new String();
this is such a cornercase that it would have absolutely no impact. but I see
your concern is for findbugs, which I did not know. thanks for pointing out.

On 2013/10/01 20:37:32, boliu wrote:
> Maybe return "" is ehh......more efficient?

[commit-bot: I haz the power, 2013-10-01 20:59:29]

Failed to trigger a try job on android_dbg
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-10-01 20:59:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/25505005/32001

[commit-bot: I haz the power, 2013-10-02 00:24:36]

Change committed as 226361