Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: net/quic/core/crypto/crypto_server_test.cc

Issue 2550493002: Deprecate FLAGS_quic_require_handshake_confirmation_pre33. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <cstdint> 6 #include <cstdint>
7 #include <memory> 7 #include <memory>
8 #include <ostream> 8 #include <ostream>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 params_(new QuicCryptoNegotiatedParameters), 114 params_(new QuicCryptoNegotiatedParameters),
115 signed_config_(new QuicSignedServerConfig), 115 signed_config_(new QuicSignedServerConfig),
116 chlo_packet_size_(kDefaultMaxPacketSize) { 116 chlo_packet_size_(kDefaultMaxPacketSize) {
117 supported_versions_ = GetParam().supported_versions; 117 supported_versions_ = GetParam().supported_versions;
118 config_.set_enable_serving_sct(true); 118 config_.set_enable_serving_sct(true);
119 119
120 client_version_ = supported_versions_.front(); 120 client_version_ = supported_versions_.front();
121 client_version_string_ = 121 client_version_string_ =
122 QuicTagToString(QuicVersionToQuicTag(client_version_)); 122 QuicTagToString(QuicVersionToQuicTag(client_version_));
123 123
124 FLAGS_quic_require_handshake_confirmation_pre33 = false;
125 FLAGS_enable_quic_stateless_reject_support = 124 FLAGS_enable_quic_stateless_reject_support =
126 GetParam().enable_stateless_rejects; 125 GetParam().enable_stateless_rejects;
127 use_stateless_rejects_ = GetParam().use_stateless_rejects; 126 use_stateless_rejects_ = GetParam().use_stateless_rejects;
128 } 127 }
129 128
130 void SetUp() override { 129 void SetUp() override {
131 QuicCryptoServerConfig::ConfigOptions old_config_options; 130 QuicCryptoServerConfig::ConfigOptions old_config_options;
132 old_config_options.id = kOldConfigId; 131 old_config_options.id = kOldConfigId;
133 delete config_.AddDefaultConfig(rand_, &clock_, old_config_options); 132 delete config_.AddDefaultConfig(rand_, &clock_, old_config_options);
134 clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1000)); 133 clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1000));
(...skipping 1012 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 // QuicCryptoServerConfig::EvaluateClientHello will leave info.unique as false 1146 // QuicCryptoServerConfig::EvaluateClientHello will leave info.unique as false
1148 // and cause ProcessClientHello to exit early (and generate a REJ message). 1147 // and cause ProcessClientHello to exit early (and generate a REJ message).
1149 config_.set_replay_protection(false); 1148 config_.set_replay_protection(false);
1150 1149
1151 ShouldSucceed(msg); 1150 ShouldSucceed(msg);
1152 EXPECT_EQ(kSHLO, out_.tag()); 1151 EXPECT_EQ(kSHLO, out_.tag());
1153 } 1152 }
1154 1153
1155 } // namespace test 1154 } // namespace test
1156 } // namespace net 1155 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698