Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2550483002: Use www.example.com instead of quic.test.url and forums.nasioc.com in QuicHttpResponseCacheTests, a… (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use www.example.com instead of quic.test.url and forums.nasioc.com in QuicHttpResponseCacheTests, as per https://tools.ietf.org/html/rfc2606#section-2 Merge internal change: 140062887 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -55 lines) Patch
D net/data/quic_http_response_cache_data/quic-datatesturl.com/index.html View 1 chunk +0 lines, -14 lines 0 comments Download
A net/data/quic_http_response_cache_data/www.example.com/index.html View 1 chunk +63 lines, -0 lines 0 comments Download
A net/data/quic_http_response_cache_data/www.example.com/map.html View 1 chunk +65 lines, -0 lines 0 comments Download
D net/data/quic_http_response_cache_data_with_push/quic-datatesturl.com/favicon.ico View Binary file 0 comments Download
D net/data/quic_http_response_cache_data_with_push/quic-datatesturl.com/index.html View 1 chunk +0 lines, -15 lines 0 comments Download
D net/data/quic_http_response_cache_data_with_push/quic-datatesturl.com/index2.html View 1 chunk +0 lines, -16 lines 0 comments Download
D net/data/quic_http_response_cache_data_with_push/quic-datatesturl.com/kitten-1.jpg View Binary file 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/www.example.com/favicon.ico View Binary file 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/www.example.com/index.html View 1 chunk +2 lines, -1 line 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/www.example.com/index2.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + net/data/quic_http_response_cache_data_with_push/www.example.com/kitten-1.jpg View Binary file 0 comments Download
M net/tools/quic/quic_http_response_cache_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years ago (2016-12-01 21:15:41 UTC) #2
Zhongyi Shi
4 years ago (2016-12-01 22:43:02 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698