Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 255047: Ensure ChromeURLRequestContext finds out first about extension loading (Closed)

Created:
11 years, 2 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Ensure ChromeURLRequestContext finds out first about extension loading. This prevents races from arising where extension renderers may try to navigate to extension urls before the request context knows how to map the urls to extension resources. BUG=22668 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27781

Patch Set 1 #

Total comments: 2

Patch Set 2 : cr changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -53 lines) Patch
M chrome/browser/extensions/extension_toolstrip_apitest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 6 chunks +50 lines, -17 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 3 chunks +9 lines, -27 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
rafaelw
11 years, 2 months ago (2009-10-01 21:59:58 UTC) #1
Matt Perry
http://codereview.chromium.org/255047/diff/1/6 File chrome/browser/net/chrome_url_request_context.h (right): http://codereview.chromium.org/255047/diff/1/6#newcode87 Line 87: void OnNewExtensions(ExtensionPaths* new_paths); I think this takes a ...
11 years, 2 months ago (2009-10-01 22:04:25 UTC) #2
rafaelw
http://codereview.chromium.org/255047/diff/1/6 File chrome/browser/net/chrome_url_request_context.h (right): http://codereview.chromium.org/255047/diff/1/6#newcode87 Line 87: void OnNewExtensions(ExtensionPaths* new_paths); On 2009/10/01 22:04:25, Matt Perry ...
11 years, 2 months ago (2009-10-01 22:32:45 UTC) #3
Matt Perry
11 years, 2 months ago (2009-10-01 22:33:59 UTC) #4
ah, much better. LGTM

http://codereview.chromium.org/255047/diff/4001/4005
File chrome/browser/net/chrome_url_request_context.cc (right):

http://codereview.chromium.org/255047/diff/4001/4005#newcode523
Line 523: if (!is_off_the_record_) {
nit: remove braces

Powered by Google App Engine
This is Rietveld 408576698