Avoid using the VideoFrame default constructor.

Avoid using the VideoFrame default constructor.

It is deprecated in webrtc, to avoid dealing with half-initialized
objects.

BUG=None.

Committed: https://crrev.com/ffd6babaa54c96e6b7f652ffb4864391c477a094
Cr-Commit-Position: refs/heads/master@{#436253}

[nisse-chromium (ooo August 14), 2016-12-02 07:51:21]

nisse@chromium.org changed reviewers:
+ sergeyu@chromium.org

[nisse-chromium (ooo August 14), 2016-12-02 07:51:22]

Hi, PTAL.

Using rtc::Optional seemed like the easiest way to delay construction of the
VideoFrame until we can assign it a valid value. Maybe there's some better way.
(And we're not yet using std::optional in chrome, right?)

I have a webrtc cl which deletes the webrtc::VideoFrame default constructor
together with the IsZeroSize method.

[Sergey Ulanov, 2016-12-02 18:24:05]

lgtm when my comment is addressed

https://codereview.chromium.org/2550453004/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
(right):

https://codereview.chromium.org/2550453004/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc:92:
rtc::Optional<webrtc::VideoFrame> output_frame_;
This this test is in chromium I think it's better to use base::Optional<> here.

[nisse-chromium (ooo August 14), 2016-12-05 09:54:36]

https://codereview.chromium.org/2550453004/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
(right):

https://codereview.chromium.org/2550453004/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc:92:
rtc::Optional<webrtc::VideoFrame> output_frame_;
On 2016/12/02 18:24:05, Sergey Ulanov wrote:
> This this test is in chromium I think it's better to use base::Optional<>
here.

Done.

[nisse-chromium (ooo August 14), 2016-12-05 09:54:44]

The CQ bit was checked by nisse@chromium.org

[nisse-chromium (ooo August 14), 2016-12-05 09:54:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2550453004/#ps20001
(title: "Use base::Optional instead of rtc::Optional.")

[commit-bot: I haz the power, 2016-12-05 09:55:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 10:23:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480931684060420,
"parent_rev": "946b957a2e14acef5e2c54cf24af298e4fd06b4b", "commit_rev":
"10ce5fd6cf2807fde51ce9565b6faae864f95964"}

[commit-bot: I haz the power, 2016-12-05 10:24:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 10:26:03]

Description was changed from

==========
Avoid using the VideoFrame default constructor.

It is deprecated in webrtc, to avoid dealing with half-initialized
objects.

BUG=None.
==========

to

==========
Avoid using the VideoFrame default constructor.

It is deprecated in webrtc, to avoid dealing with half-initialized
objects.

BUG=None.

Committed: https://crrev.com/ffd6babaa54c96e6b7f652ffb4864391c477a094
Cr-Commit-Position: refs/heads/master@{#436253}
==========

[commit-bot: I haz the power, 2016-12-05 10:26:04]

Patchset 2 (id:??) landed as
https://crrev.com/ffd6babaa54c96e6b7f652ffb4864391c477a094
Cr-Commit-Position: refs/heads/master@{#436253}