Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2550443002: Fix a minor issue in OffscreenCanvas.drawImage (Closed)

Created:
4 years ago by xidachen
Modified:
4 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a minor issue in OffscreenCanvas.drawImage This CL fixes the problem in OffscreenCanvas.drawImage function when it takes another OffscreenCanvas without a context as its image source. In this case, it should draw transparent black. However, currently this is not currently handled. This CL also adds a layout test to verify the case. BUG=670393 Committed: https://crrev.com/c5164dcf766dffdbbe6575e7c7c68cb920698c8a Cr-Commit-Position: refs/heads/master@{#435723}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-no-context.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
xidachen
PTAL
4 years ago (2016-12-01 19:35:35 UTC) #2
Justin Novosad
lgtm with nits https://codereview.chromium.org/2550443002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-noContext.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-noContext.html (right): https://codereview.chromium.org/2550443002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-noContext.html#newcode1 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-noContext.html:1: <!DOCTYPE HTML> Nit: the file name ...
4 years ago (2016-12-01 19:39:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550443002/20001
4 years ago (2016-12-01 21:32:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 21:40:47 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 21:43:29 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c5164dcf766dffdbbe6575e7c7c68cb920698c8a
Cr-Commit-Position: refs/heads/master@{#435723}

Powered by Google App Engine
This is Rietveld 408576698