Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: src/objects.cc

Issue 2550423002: Propagate exceptions thrown by access check interceptors. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-access-checks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index d0e40b94859e2fe81f0ec3d05bcffadd3431581b..6e2f260bf8bb073f17db3e7a0277b46f2d497569 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1885,10 +1885,8 @@ Maybe<bool> JSObject::SetPropertyWithFailedAccessCheck(
return SetPropertyWithAccessor(it, value, should_throw);
}
} else {
- Maybe<bool> result = SetPropertyWithInterceptorInternal(
- it, interceptor, should_throw, value);
- RETURN_VALUE_IF_SCHEDULED_EXCEPTION(isolate, Nothing<bool>());
- if (result.IsJust()) return result;
+ return SetPropertyWithInterceptorInternal(it, interceptor, should_throw,
+ value);
}
isolate->ReportFailedAccessCheck(checked);
jochen (gone - plz use gerrit) 2016/12/06 10:05:22 maybe move these lines into the if () { } block, s
« no previous file with comments | « no previous file | test/cctest/test-access-checks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698