Propagate exceptions thrown by access check interceptors.

test/cctest/test-access-checks.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "test/cctest/cctest.h"
 
 namespace {
 
@@ skipping 16 matching lines @@
   v8::Isolate* isolate = info.GetIsolate();
   v8::Local<v8::Context> context = isolate->GetCurrentContext();
   if (!property->Equals(context, v8_str("cross_context_int")).FromJust())
     return;
   if (value->IsInt32()) {
     g_cross_context_int = value->ToInt32(context).ToLocalChecked()->Value();
   }
   info.GetReturnValue().Set(value);
 }
 
+void NamedSetterThrowsException(
+    v8::Local<v8::Name> property, v8::Local<v8::Value> value,
+    const v8::PropertyCallbackInfo<v8::Value>& info) {
+  info.GetIsolate()->ThrowException(v8_str("exception"));
+}
+
 void NamedQuery(v8::Local<v8::Name> property,
                 const v8::PropertyCallbackInfo<v8::Integer>& info) {
   CHECK(g_expect_interceptor_call);
   v8::Isolate* isolate = info.GetIsolate();
   v8::Local<v8::Context> context = isolate->GetCurrentContext();
   if (!property->Equals(context, v8_str("cross_context_int")).FromJust())
     return;
   info.GetReturnValue().Set(v8::DontDelete);
 }
 
@@ skipping 127 matching lines @@
   }
 
   // Intercepted properties are accessible, however.
   ExpectInt32("this.other.cross_context_int", 23);
   CompileRunChecked(isolate, "this.other.cross_context_int = 42");
   ExpectInt32("this.other[7]", 42);
   ExpectString("JSON.stringify(Object.getOwnPropertyNames(this.other))",
                "[\"7\",\"cross_context_int\"]");
 }
 
+void CheckCrossContextSetterWithException(
+    v8::Isolate* isolate, v8::Local<v8::Context> accessing_context,
+    v8::Local<v8::Object> accessed_object) {
+  v8::HandleScope handle_scope(isolate);
+  accessing_context->Global()
+      ->Set(accessing_context, v8_str("other"), accessed_object)
+      .FromJust();
+  v8::Context::Scope context_scope(accessing_context);
+
+  v8::TryCatch try_catch(isolate);
+  CompileRun("this.other.should_throw = 8");
+  CHECK(try_catch.HasCaught());
+  CHECK(try_catch.Exception()->IsString());
+  CHECK(v8_str("exception")
+            ->Equals(accessing_context, try_catch.Exception())
+            .FromJust());
+}
+
 void Ctor(const v8::FunctionCallbackInfo<v8::Value>& info) {
   CHECK(info.IsConstructCall());
 }
 
 }  // namespace
 
 TEST(AccessCheckWithInterceptor) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   v8::Local<v8::ObjectTemplate> global_template =
@@ skipping 14 matching lines @@
   v8::Local<v8::Context> context0 =
       v8::Context::New(isolate, nullptr, global_template);
   CheckCanRunScriptInContext(isolate, context0);
 
   // Create another context.
   v8::Local<v8::Context> context1 =
       v8::Context::New(isolate, nullptr, global_template);
   CheckCrossContextAccess(isolate, context1, context0->Global());
 }
 
+TEST(AccessCheckWithExceptionThrowingSetterInterceptor) {
+  v8::Isolate* isolate = CcTest::isolate();
+  isolate->SetFailedAccessCheckCallbackFunction([](v8::Local<v8::Object> target,
+                                                   v8::AccessType type,
+                                                   v8::Local<v8::Value> data) {
+    CHECK(false);  // This should never be called.
+  });
+
+  v8::HandleScope scope(isolate);
+  v8::Local<v8::ObjectTemplate> global_template =
+      v8::ObjectTemplate::New(isolate);
+  global_template->SetAccessCheckCallbackAndHandler(
+      AccessCheck, v8::NamedPropertyHandlerConfiguration(
+                       NamedGetter, NamedSetterThrowsException),
+      v8::IndexedPropertyHandlerConfiguration());
+
+  // Create two contexts.
+  v8::Local<v8::Context> context0 =
+      v8::Context::New(isolate, nullptr, global_template);
+  v8::Local<v8::Context> context1 =
+      v8::Context::New(isolate, nullptr, global_template);
+
+  // Try setting a cross-context property, which should throw an exception but
+  // not invoke the access failed callback.
+  CheckCrossContextSetterWithException(isolate, context1, context0->Global());
+}
+
 TEST(NewRemoteContext) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   v8::Local<v8::ObjectTemplate> global_template =
       v8::ObjectTemplate::New(isolate);
   global_template->SetAccessCheckCallbackAndHandler(
       AccessCheck,
       v8::NamedPropertyHandlerConfiguration(
           NamedGetter, NamedSetter, NamedQuery, NamedDeleter, NamedEnumerator),
       v8::IndexedPropertyHandlerConfiguration(IndexedGetter, IndexedSetter,
@@ skipping 68 matching lines @@
                                               IndexedEnumerator));
   tmpl->SetNativeDataProperty(
       v8_str("all_can_read"), Return42, nullptr, v8::Local<v8::Value>(),
       v8::None, v8::Local<v8::AccessorSignature>(), v8::ALL_CAN_READ);
 
   v8::Local<v8::Object> obj = tmpl->NewRemoteInstance().ToLocalChecked();
 
   v8::Local<v8::Context> context = v8::Context::New(isolate);
   CheckCrossContextAccess(isolate, context, obj);
 }