Issue 255042: Reverting 27711.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255042: Reverting 27711. (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move various methods from glue/webview.h to api/public/WebView.h I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Originally reviewed here: http://codereview.chromium.org/251051 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27780

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -179 lines)			Patch
M	chrome/renderer/print_web_view_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View		7 chunks	+9 lines, -14 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/public/WebView.h	View		4 chunks	+35 lines, -1 line	0 comments	Download
M	webkit/glue/chrome_client_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/dom_operations.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/mimetype_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1	5 chunks	+15 lines, -25 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webview.h	View		3 chunks	+0 lines, -52 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		3 chunks	+10 lines, -21 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1	10 chunks	+16 lines, -41 lines	0 comments	Download
M	webkit/glue/webview_unittest.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	webkit/glue/webworker_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_shell_webview.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/mac/webview_host.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/webview_host_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/webview_host_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages