Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2550413002: Make ifdefs consistent in WebKit/Source/modules/accessibility/. (Closed)

Created:
4 years ago by Alexander Alekseev
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ifdefs consistent in WebKit/Source/modules/accessibility/. This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG=666660 Committed: https://crrev.com/930defe2fb5074c1898c0d221c6d22e0d9a289b2 Cr-Commit-Position: refs/heads/master@{#436727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Alexander Alekseev
setHasAXObject() is hidden behind #if DCHECK_IS_ON() condition, so this Cl makes these conditions consistent. Please ...
4 years ago (2016-12-06 09:32:55 UTC) #4
dmazzoni
lgtm
4 years ago (2016-12-06 16:06:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550413002/1
4 years ago (2016-12-06 21:03:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 21:17:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 21:19:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930defe2fb5074c1898c0d221c6d22e0d9a289b2
Cr-Commit-Position: refs/heads/master@{#436727}

Powered by Google App Engine
This is Rietveld 408576698