Chromium Code Reviews
DescriptionMake ifdefs consistent in WebKit/Source/modules/accessibility/.
This CL addresses a few problems with #ifdefs:
1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.
2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.
BUG=666660
Committed: https://crrev.com/930defe2fb5074c1898c0d221c6d22e0d9a289b2
Cr-Commit-Position: refs/heads/master@{#436727}
Patch Set 1 #
Messages
Total messages: 13 (8 generated)
|
|||||||||||||||||||